Repository navigation
feat(import): let phones from different brands share a codename - #77
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
scripts
This was referenced Oct 19, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Scripts
Overview
The weekly import skipped any phone whose codename another brand already had, so a few with real builds never got a page. The Teracube 2s is
sapphire, same as a Redmi, and the POCO F7 isonyx, same as a OnePlus. Devices are keyed by brand and codename now (their path underdata/devices/), so two brands can each have asapphire.Once this is in, the next import adds the Teracube 2s, POCO F7, Xiaomi 11T and realme X2. The other three were already here under codenames LineageOS renamed to dodge the same clash, so their builds go on the existing pages instead:
tulipon the Redmi Note 6 Pro (twolip's tree asserts both),siriuson the Mi 8 SE andoscaron the Nord CE 2 Lite 5G.Issue Number
None
Additional Info
Support files move to
data/support/<brand>/<codename>/<rom>.ymland the upstream files are rekeyed, which is most of the diff. That part's mechanical - the joined data comes out the same bar those 14 paths, and the built API matches the live one apart from a newbrandon support rows andidon devices.The report button prefills the device as
brand/codenamenow, as five pages share a title (three POCO M3s and two Redmi 7As).