Repository navigation
fix(import): stop listing a phone's own name as its model number - #80
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
device
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Device
Overview
When a second ROM names a phone, the import adds that ROM's other names as aliases, and if one of them was the phone's own name it went in too. So seven pages showed their own name under "Model numbers" - the POCO F4 page lists "POCO F4", the Mi 9T "Mi 9T" and so on. The import skips an alias that matches the device's name now, and those seven are tidied up.
Issue Number
None
Additional Info
The full import run locally on this branch puts none of them back, and stock dates still match the same 277 phones (they join on the name first anyway). The new test fails on the old store. Tests and validate pass.