Skip to content

Metadataset improvements and example fixes#283

Merged
navidcy merged 2 commits into
mainfrom
ncc/metadata-improvements
May 24, 2026
Merged

Metadataset improvements and example fixes#283
navidcy merged 2 commits into
mainfrom
ncc/metadata-improvements

Conversation

@navidcy
Copy link
Copy Markdown
Member

@navidcy navidcy commented May 23, 2026

This PR pulls some of the changes in #277.

This is to ensure Docs examples can built before we debug the visualisation changes. Building all docs is ~7hrs so it's hard to iterate.

@navidcy navidcy added build all examples add this label to build all the examples in the PR data wrangling 🗃️ JRA55, ECCO, ERA5, and friends labels May 23, 2026
@navidcy navidcy requested a review from glwagner May 23, 2026 21:30
@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/DataWrangling/metadata.jl 80.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@navidcy navidcy merged commit 6f7581b into main May 24, 2026
10 checks passed
@navidcy navidcy deleted the ncc/metadata-improvements branch May 24, 2026 11:08
@glwagner
Copy link
Copy Markdown
Member

This PR pulls some of the changes in #277.

This is to ensure Docs examples can built before we debug the visualisation changes. Building all docs is ~7hrs so it's hard to iterate.

Just note for the future, a good way to iterate on examples is to do them one by one (rather than building all of them every time). This can be done by commenting the examples out in make.jl and using the tag "build all examples".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build all examples add this label to build all the examples in the PR data wrangling 🗃️ JRA55, ECCO, ERA5, and friends

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants