Skip to content

[15.0][MIG] product_multi_image#1070

Merged
OCA-git-bot merged 16 commits into
OCA:15.0from
flachica:15.0-mig-product_multi_image
Aug 25, 2022
Merged

[15.0][MIG] product_multi_image#1070
OCA-git-bot merged 16 commits into
OCA:15.0from
flachica:15.0-mig-product_multi_image

Conversation

@flachica

@flachica flachica commented May 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

@flachica flachica force-pushed the 15.0-mig-product_multi_image branch 3 times, most recently from c42255a to 011da50 Compare May 6, 2022 12:05
@flachica flachica mentioned this pull request May 6, 2022
Closed
65 tasks
@rousseldenis

rousseldenis commented May 17, 2022

Copy link
Copy Markdown
Contributor

/ocabot migration product_multi_image

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone May 17, 2022
@rousseldenis

rousseldenis commented May 17, 2022

Copy link
Copy Markdown
Contributor

@flachica Thanks for this. Could you add link in PR description to OCA/server-tools#2334 ?

This was referenced May 18, 2022
Closed
Merged
Open
Merged
Closed
@jacekmichalski

jacekmichalski commented Aug 8, 2022

Copy link
Copy Markdown
Contributor

@rousseldenis or @pedrobaeza Could you rerun Github Actions, the logs have expired and I would like to know why runboat has failed.

@pedrobaeza

pedrobaeza commented Aug 8, 2022

Copy link
Copy Markdown
Member

A rebase is needed from the original author.

@flachica flachica force-pushed the 15.0-mig-product_multi_image branch from 011da50 to ce2ae62 Compare August 8, 2022 15:25
@flachica

flachica commented Aug 8, 2022

Copy link
Copy Markdown
Contributor Author

A rebase is needed from the original author.

Rebased

jacekmichalski
jacekmichalski approved these changes Aug 8, 2022
View reviewed changes

@jacekmichalski jacekmichalski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems fine

@jacekmichalski

jacekmichalski commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

@rousseldenis could you review the code?

@jacekmichalski

jacekmichalski commented Aug 10, 2022

Copy link
Copy Markdown
Contributor

@pedrobaeza maybe you could review the code?

@pedrobaeza

pedrobaeza commented Aug 10, 2022

Copy link
Copy Markdown
Member

Sorry, not using it.

pedrobaeza and others added 8 commits August 17, 2022 12:37
@pedrobaeza @flachica
product_multi_image: Module totally redone from old product_images
151f06a
@yajo @flachica
[IMP] product_multi_image: Split model in abstract & concrete + bette…
5d38e9f 
…r icon
@yajo @flachica
Fix bugs found in review time, improve README.
2a68aab
@pedrobaeza @flachica
product_multi_image: Handle images in variants
647b5e5
@lasley @flachica
[MIG] product_multi_image: Upgrade to v9
d926edb 
* Upgrade product_multi_image to v9
* Add server-tools to oca_dependencies
@lasley @flachica
[MIG] product_multi_image: Upgrade to v10
0e84b56 
* Migrate product_multi_image to v10
* Remove old api from `product.product`
* Add test coverage for hooks and variant count
* Fix oca depends
* Add uninstall hook
@simahawk @flachica
[fix] prod image update broken w/ no image on template OCA#228
34caa13
@flachica
[IMP] product_multi_image: Improve uninstall hook to move images from
08c6b24 
multi to single mode
@flachica flachica force-pushed the 15.0-mig-product_multi_image branch from ce2ae62 to b443833 Compare August 17, 2022 10:38
@jacekmichalski

jacekmichalski commented Aug 23, 2022

Copy link
Copy Markdown
Contributor

@hailangvn could you review the code? We need one more code review. I would be greatful! Thanks in advance! ;-)

@OCA-git-bot

OCA-git-bot commented Aug 23, 2022

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@jacekmichalski

jacekmichalski commented Aug 25, 2022

Copy link
Copy Markdown
Contributor

@pedrobaeza can you merge this one?

@pedrobaeza

pedrobaeza commented Aug 25, 2022

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Aug 25, 2022

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-1070-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 946d258 into OCA:15.0 Aug 25, 2022
@OCA-git-bot

OCA-git-bot commented Aug 25, 2022

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at dc6504d. Thanks a lot for contributing to OCA. ❤️

@flachica flachica mentioned this pull request Sep 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes
+1 more reviewer
@jacekmichalski jacekmichalski jacekmichalski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 migration needs review ready to merge

Projects

None yet

Milestone

15.0

Development

Successfully merging this pull request may close these issues.

10 participants

@flachica @rousseldenis @jacekmichalski @pedrobaeza @OCA-git-bot @yajo @lasley @simahawk @MPoch-PlanetaTIC @hailangvn