Release 1.0.3: fix stale README version + enforce version consistency - #28
Merged
Merged
Conversation
PyPI's sidebar only renders Author/Maintainer, so contributor credit lives in the project description (README). Promote the buried Attribution line into a dedicated 'Authors and contributors' section so Fred Viole (author/maintainer) and contributors Roberto Spadim and Rasheed Khoshnaw are clearly visible on the PyPI page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What went wrong
The README has a hand-maintained
| Current version | ... |row. It was bumped for 1.0.1 but not for 1.0.2, so the published 1.0.2 PyPI page (the README is the project description) shows "Current version 1.0.1" — contradicting the real version. PyPI versions are immutable, so the fix ships as 1.0.3.Fix + permanent guard
pyproject,nns.__version__, and the README current-version row to 1.0.3.scripts/check_version_consistency.py— fails ifpyproject [project].version,nns.__version__, and the README current-version row disagree.release.yml(runs on every release, including TestPyPI dry runs) → a stale version can never be published again.tests/tools/test_version_sync.py→ PR CI catches the drift on the bump itself.Validation
release.ymlparses; version-sync test passes;twine check --strictpasses onovvo_nns-1.0.3.tar.gz; provenance gate passes forv1.0.3.https://claude.ai/code/session_012bjk4Y5eT1Sva8tNJjqUSw
Generated by Claude Code