feat: show skipped manifest dependencies in the HTML report#841
Merged
sonukapoor merged 1 commit intoJul 18, 2026
Merged
Conversation
The terminal output already lists dependencies that were skipped during a scan (printSkippedDependencies), but the HTML report had no equivalent, so anyone reading the report had no visibility into what was excluded from it. Thread scanInput.skippedDependencies through buildReportData into ReportData and render a "Skipped manifest dependencies" section, mirroring the existing skipped-findings card. The list is also carried in report.json now that it is part of ReportData. The section is omitted entirely when nothing was skipped.
Collaborator
|
Merged - thank you @ELHart05! |
This was referenced Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The terminal output already lists dependencies that were skipped during a scan (via
printSkippedDependencies), but the HTML report had no equivalent, so anyone reading the report couldn't tell what was left out of it. This adds a "Skipped manifest dependencies" section to the HTML report.Why this change
When a scan can't resolve some manifest dependencies (private-registry packages, git/file specifiers, version ranges it can't parse), they're silently absent from the HTML report. A reader has no way to distinguish "the report covered the whole tree" from "part of the tree was quietly skipped." The terminal already surfaces this list; the report should too.
What changed
scanInput.skippedDependenciesthroughbuildReportDataintoReportData.ReportData, it also appears in thereport.jsonwritten alongside the HTML.tests/html-reporter.test.ts: pass-through, rendering + count, HTML-escaping of specifiers, and empty-case omission.Validation
npm run build(stricttsc) passes.npm testfor the reporter suite passes, including the 4 new tests; also eyeballed the rendered fragment to confirm layout and escaping.User-facing impact
Does this change:
Notes
The section adds no new client-side JS and reuses the existing card styling, so it inherits the report's light/dark theming and needs no interactivity.
Closes #234