fix jsdom undefined nodeType for attributes#24
Open
chiptus wants to merge 2 commits into
Open
Conversation
Owner
|
@chiptus Let's remove last commit there are code style changes are made. It is not clean where is the main changes are. |
Author
|
reverted the changes and made the hotfix without style changes. |
Owner
|
I don't think this fix is sufficient. What about this line: https://github.com/Olegas/dom-compare/blob/master/lib/compare.js#L104 ? Here we need to know the correct node type to select proper comparison strategy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a quickfix for cases where nodeType is undefined. it will check that the objects has the same constructor - meaning the same Class.
fix #22
It has changes in all files because I applied prettier on the files.