Skip to content

fix jsdom undefined nodeType for attributes#24

Open
chiptus wants to merge 2 commits into
Olegas:masterfrom
chiptus:master
Open

fix jsdom undefined nodeType for attributes#24
chiptus wants to merge 2 commits into
Olegas:masterfrom
chiptus:master

Conversation

@chiptus
Copy link
Copy Markdown

@chiptus chiptus commented Apr 26, 2017

I added a quickfix for cases where nodeType is undefined. it will check that the objects has the same constructor - meaning the same Class.

fix #22

It has changes in all files because I applied prettier on the files.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 26, 2017

Coverage Status

Coverage increased (+0.5%) to 92.308% when pulling bce38dd on chiptus:master into ac6eb6f on Olegas:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 26, 2017

Coverage Status

Coverage increased (+0.5%) to 92.308% when pulling 63d8ded on chiptus:master into ac6eb6f on Olegas:master.

@Olegas
Copy link
Copy Markdown
Owner

Olegas commented Apr 27, 2017

@chiptus Let's remove last commit there are code style changes are made. It is not clean where is the main changes are.

@chiptus
Copy link
Copy Markdown
Author

chiptus commented Apr 30, 2017

reverted the changes and made the hotfix without style changes.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 30, 2017

Coverage Status

Coverage decreased (-1.1%) to 90.65% when pulling 3d86a79 on chiptus:master into 4fbf204 on Olegas:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 30, 2017

Coverage Status

Coverage decreased (-1.1%) to 90.65% when pulling 3d86a79 on chiptus:master into 4fbf204 on Olegas:master.

@Olegas
Copy link
Copy Markdown
Owner

Olegas commented May 1, 2017

I don't think this fix is sufficient. What about this line: https://github.com/Olegas/dom-compare/blob/master/lib/compare.js#L104 ?

Here we need to know the correct node type to select proper comparison strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comparing attributes gives 'nodeType is unexpected' error

3 participants