Skip to content

fix jsdom undefined nodeType for attributes #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chiptus wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix jsdom undefined nodeType for attributes #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
761fbf6
quickfix for jsdom no nodetype for attribute
chiptus Apr 30, 2017
3d86a79
Merge branch 'master' of github.com:Olegas/dom-compare
chiptus Apr 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions lib/collector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,19 @@
msg = "Expected text '" + vExpected + "' instead of '" + vActual + "'";
break;
default:
//if they are the same class of objects and undefined nodeType, assumes attribute
//TODO remove when jsdom fix this
if (expected.constructor === actual.constructor) {
msg =
"Attribute '" +
expected.nodeName +
"': expected value '" +
vExpected +
"' instead of '" +
vActual +
"'";
break;
}
throw new Error("nodeValue is not equal, but nodeType is unexpected");
}
canContinue = true;
Expand Down