Repository navigation
Build puzzle plates watertight where four pieces meet at 0.35 mm, and keep corner pockets out of a key's cup - #82
Merged
Conversation
…m fit clearance Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
…ve, and Checks says so Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
… edits, so the two merge cleanly Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
… and the docs say the rule keeps them closed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
…tes, as closed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
…s put in from beneath Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Oliver-Johnson
pushed a commit
that referenced
this pull request
Oct 10, 2026
#82 adds the housing of a key put in from above to the joint cuts mountLimits measures (its bottom), and this branch adds the cut's outline (segs) for the turned shank's reach; both fields are kept on the one jointCuts.push line. sw.js and the pages rebuilt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Oliver-Johnson
pushed a commit
that referenced
this pull request
Oct 10, 2026
Only sw.js conflicted, on its VERSION line; taken from main and rebuilt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XjNf7SQF9o4ZVeWiSbWQmk
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Oliver · project thread
What this changes
Closes #72
Closes #75
#72: puzzle tabs at a 0.35 mm fit, where four pieces meet
#75: a wall key put in from above, beside a corner boss's pocket
footprint) and the underside (bottom); the geometry is unchanged. A pocket from beneath clears the cup by stopping MOUNT_LEVEL under it; a pocket from above or a shank meets any cup it reaches; MOUNT_SEAM applies as for the other cuts.Left for later, on main too: the socket's rim stands in a big corner pocket at small pitches with no joint (about 1.9 mm³ in a 6 mm pocket at 36.13 mm). Filed as #83.
New top-level names: none (checked against main f9873f5 and #81). #81 also adds a field to the same
jointCuts.pushline in core.js, so whichever merges second resolves it asjointCuts.push({ top: ceiling, bottom, segs, sites }); a trial merge with #81's current head 02a78f3 builds and passes the full plate audit.Checks
src/, not the generatedindex.html/bins/index.htmlnode build.jsand committed the regenerated pages alongside the sourcesnpm run test:allpasses (run here:npm test, ci-sim, and the plate UI specs plates-input, plates-robustness, export, keys and half-cells, 172 passed; not the whole UI suite)If this touches geometry
node test/bin-audit.jsreportsall cases cleannode test/plate-audit.jsreportsall plates watertight, and no case has picked up bad edges that were not already named as knownpuzzle 42 quads, 0.35(fails on main, A2 and B2 one edge each); eight rows on the corner pockets beside a key put in from above: six measure each pocket's open room (five fail on main; the 42 mm control is taken on both), and two require the plate closed at the size taken (both fail on main, with 4 and 26 open edges); and two page tests for the refusal (both fail on main)🤖 Generated with Claude Code
https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY