Repository navigation
Close the open edges beside a magnet pocket when a clip or key is put in from above - #88
Merged
Merged
Conversation
…pen beside a magnet pocket from beneath Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Oliver-Johnson
pushed a commit
that referenced
this pull request
Oct 10, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Oliver · project thread
What this changes
Before. On a solid floor, with an H-clip or snap clip put in from above, some magnet sizes from beneath left piece A1 with 3 to 14 open edges at the joint's housing, and Download stayed on. The issue's case is a 6.3 mm magnet at 34.5 mm (4 open edges with the H-clip, 3 with the wall snap clip); a 6.25 mm magnet at 37.5 mm left 14. Wall keys put in from above did the same at some sizes.
After. These plates build watertight. No magnet size is refused that was taken before, and no cap, Checks wording or field limit changes. Of 40,884 designs swept (38,013 of them sizes the field takes), 176 came out open here before, every one with its joint put in from above, and all 176 come out closed now with no fold; exactly those 176 build other bytes. 600 random designs (510 built) build main c0dc948's bytes (984 pieces), and none takes the new path.
How. The issue guessed the pocket's cap shared a plane with the housing. It does not: a magnet from beneath stops 2.2 mm under an H-clip's cup (2.1 under a snap clip's slot). What lines up is a flat of the pocket. The BSP carries its plane across the whole cell and splits the cell's faces where it crosses them; at 34.5 mm with 6.3 mm the nearest flat crosses the side of the cell's region 0.019 mm from the seam face, beside the corner the region's top face is fanned from. The spokes there are microns apart, the weld in
healCsgSeamschains and moves the side's top corner 3.4 microns off its plane, and the housing, cut afterwards, crosses that face with its end wall 1.9 and 2.5 microns off it at its two ends, which the weld joins at one end and not the other. Moving the housing, ascutAgaindoes, leaves the face as it is. So inbuildPiece's top-insert pass, a whole cell whose housing still comes out open has its pockets cut again the wayssettlealready does (moved 1.7 microns along a diagonal, turned a 28th of a turn, or both), the housing cut out of each try, and the first that comes out closed, with nothing turned over and no more edges shared with the shells beside it, is kept. A housing that comes out closed is built as before. The cost is at most seven pocket cuts and housing cuts for one cell, on designs that came out open. 20 of the 176 are wall-key cups from above, which the issue does not name. The report is /mnt/project-files/issue-batches/issue-85-report.md.Two defects the sweep found, the same on main, are not touched here and are filed as #89: a wall bowtie from above at tight tolerance, 37.5 mm, 7.8 mm magnet (2 edges used four times), and a wall puzzle key from above at loose tolerance (2 folds at 39.5 mm with 11.2 mm, the cap, and at 42.5 mm with 5.8 mm).
Closes #85.
Checks
src/, not the generatedindex.html/bins/index.htmlnode build.jsand committed the regenerated pages alongside the sourcesnpm run test:allpasses (run here on 3140d62:npm test(the bin and plate audits among them) andnode test/ci-sim.jsclean; the plate UI specs plates-input, plates-robustness, export, keys and half-cells, 186 passed; CI's check and ui jobs, the whole UI suite, both passed on 3140d62)If this touches geometry
node test/bin-audit.jsreportsall cases cleannode test/plate-audit.jsreportsall plates watertight, and no case has picked up bad edges that were not already named as known🤖 Generated with Claude Code
https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY