Repository navigation
A cap that comes out open is fanned again from a point clear of the pocket's corners - #96
Merged
Merged
Conversation
… into no longer come out open on the bottom face A cell whose bottom face comes out open after its pockets' tries has that face fanned again from a point clear of the mounting cutters' corners alone, and its cuts taken again on it; the new cut is kept only if it is closed with nothing turned over and shares no more edges with the cells beside it. Cells that come out closed are fanned as before, so every design that already built closed keeps its bytes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
…open on a boss's top A boss whose pocket still comes out open after every try has its top fanned again from a point inside it clear of the corners of the walls that open on the top, and its pocket cut again; the new cut is kept only if it is closed with nothing turned over and shares no more edges with the shells beside it. Bosses that come out closed keep the fan from their corner, so every design that already built closed keeps its bytes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
…a boss's underside A boss's underside is fanned from its corner the same way as its top, and a 4.9 mm magnet from beneath at 43.9 mm left 3 open edges a cell there. A boss still open after its tries now has whichever cap it is open on, top or underside or both, fanned again clear of its cutter's corners at that height, kept on the same terms as before. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
…L, and that no audit row asserts the joint half of the corner test Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Oliver · project thread
What this changes
Two kinds of baseplate came out with a sliver missing from a flat face, so the downloaded mesh had a few open edges in every cell.
Before
After
How
refanCaps), and its pocket cut again.Merged with #90 and #93. A boss at a rounded plate corner is now cut to the arc (#90), and its cut is taken only if it comes out closed with nothing turned over. The refan runs inside that test, so a cut boss that came out open on its first try is fanned again before the test, and not only after it has failed. 7 of 2,266 designs that were closed on main (7c2103d) build other bytes for that reason: their corner boss was cut to the arc on both, and closed on main only after the second try with the cutter turned a 28th of a turn, and now closes on the first try. Same open, four-use, fold, wound and inverted counts on both, and the boss is cut to the arc on both (checked at the corner).
Two small ENGINE.md wording changes review asked for on #90 ride here: the chords' sag can put a bore up to 0.021 mm under
MOUNT_WALLfrom the outline, and no audit row asserts the joint half of the corner test.The full write-up is /mnt/project-files/issue-batches/issue-91-92-report.md.
Checks
src/, not the generatedindex.html/bins/index.htmlnode build.jsand committed the regenerated pages alongside the sourcesnpm run test:allpasses (run here on 9b621c0, the merge with main 7c2103d:npm testexit 0 with 0 FAIL, and the plate UI specs plates-input, plates-robustness, export, keys and half-cells 186 passed. The two commits after it change only ENGINE.md and a comment in plate-audit.js;node build.js --checkis clean andnode test/ci-sim.jssays "CI will pass." on the head. The whole UI suite is left to CI)If this touches geometry
node test/bin-audit.jsreportsall cases cleannode test/plate-audit.jsreportsall plates watertight, and no case has picked up bad edges that were not already named as known (the new 2 x 2 rows keep the quarantined edges between bosses, the same count as main)Sweeps, each design built on the head and on its base in one process, comparing every piece's triangles byte for byte:
Closes #91.
Closes #92.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY