Skip to content

fix: support legacy bundle checkouts#12540

Open
huhuanming wants to merge 2 commits into
xfrom
codex/fix-legacy-bundle-ci
Open

fix: support legacy bundle checkouts#12540
huhuanming wants to merge 2 commits into
xfrom
codex/fix-legacy-bundle-ci

Conversation

@huhuanming

@huhuanming huhuanming commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep the release bundle workflows compatible with legacy PR checkouts that predate the Rspack production-asset helper scripts
  • skip web-embed Sentry debug-ID injection when the post-injection Chromium 67 checker is unavailable
  • fall back to inline sourcemap and license-file cleanup for legacy web-embed and desktop bundles

Root cause

release-app-bundles runs the workflow definition from x but checks out the selected PR head before building. Release-branch PRs created before the Rspack migration do not contain check-browser-compat.js or finalize-production-assets.js, so the newer workflow failed with MODULE_NOT_FOUND after successful bundle compilation.

Impact

Legacy release PRs can be built by the current x workflow without shipping sourcemaps or license artifacts. Current checkouts retain the existing Sentry injection, Chromium 67 verification, and finalizer behavior.

Validation

  • yarn lint:agent-context
  • yarn lint:staged
  • yarn tsc:staged
  • YAML parse and Bash syntax checks for the modified workflow steps
  • synthetic legacy production-asset cleanup check
  • release-app-bundles run 29568580576: all web-embed, desktop, web, iOS, Android, and QA upload jobs passed

@huhuanming
huhuanming force-pushed the codex/fix-legacy-bundle-ci branch from d594221 to 58ca30c Compare July 17, 2026 09:03
@huhuanming
huhuanming force-pushed the codex/fix-legacy-bundle-ci branch from 58ca30c to ee72921 Compare July 17, 2026 10:51
@huhuanming
huhuanming marked this pull request as ready for review July 17, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant