Skip to content

fix: support legacy bundle checkouts #12540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
originalix merged 2 commits into from
Jul 17, 2026
+50 −5
Merged

fix: support legacy bundle checkouts #12540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee72921
fix: support legacy bundle checkouts
huhuanming Jul 17, 2026
f63cfb4
Merge branch 'x' into codex/fix-legacy-bundle-ci
huhuanming Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 31 additions & 4 deletions .github/workflows/release-app-bundles.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,12 @@ jobs:
# shellcheck disable=SC2088
URL_PREFIX='~/web-embed'
npx sentry-cli releases new "$RELEASE" || true
if ! npx sentry-cli sourcemaps inject ./apps/web-embed/web-build; then
echo "::warning::Web-embed Sentry debug-id injection failed; continuing with release-based upload."
if [ -f ./apps/web-embed/scripts/check-browser-compat.js ]; then
if ! npx sentry-cli sourcemaps inject ./apps/web-embed/web-build; then
echo "::warning::Web-embed Sentry debug-id injection failed; continuing with release-based upload."
fi
else
echo "::notice::Skipping Sentry debug-id injection for a legacy checkout without the post-injection browser compatibility check."
fi
if npx sentry-cli sourcemaps upload --release "$RELEASE" --url-prefix "$URL_PREFIX" ./apps/web-embed/web-build; then
npx sentry-cli releases finalize "$RELEASE" || true
Expand All @@ -264,7 +268,12 @@ jobs:
fi

- name: Verify injected Web-embed Chromium 67 compatibility
run: node ./apps/web-embed/scripts/check-browser-compat.js
run: |
if [ -f ./apps/web-embed/scripts/check-browser-compat.js ]; then
node ./apps/web-embed/scripts/check-browser-compat.js
else
echo "::notice::Skipping the Chromium 67 compatibility check for a legacy checkout."
fi

- name: Upload Web-embed Sourcemap Diagnostic Artifact
if: always() && steps.upload_web_embed_sourcemaps.outputs.uploaded != 'true'
Expand All @@ -280,7 +289,25 @@ jobs:

- name: Finalize Web-embed Production Assets
if: always()
run: node ./apps/web-embed/scripts/finalize-production-assets.js --strip-only
run: |
if [ -f ./apps/web-embed/scripts/finalize-production-assets.js ]; then
node ./apps/web-embed/scripts/finalize-production-assets.js --strip-only
else
echo "::notice::Using legacy web-embed production asset cleanup."
find ./apps/web-embed/web-build -type f \( \
-name '*.css.map' -o \
-name '*.js.map' -o \
-name '*.LICENSE.txt' \
\) -print -delete
if find ./apps/web-embed/web-build -type f \( \
-name '*.css.map' -o \
-name '*.js.map' -o \
-name '*.LICENSE.txt' \
\) -print -quit | grep -q .; then
echo "::error::Legacy web-embed production asset cleanup left sourcemap or license files behind."
exit 1
fi
fi

- name: Upload web-embed artifact
uses: actions/upload-artifact@v4
Expand Down
20 changes: 19 additions & 1 deletion .github/workflows/release-desktop-bundle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,25 @@ jobs:

- name: Finalize Desktop Bundle Production Assets
if: always()
run: node ./apps/desktop/scripts/finalize-production-assets.js --strip-only
run: |
if [ -f ./apps/desktop/scripts/finalize-production-assets.js ]; then
node ./apps/desktop/scripts/finalize-production-assets.js --strip-only
else
echo "::notice::Using legacy desktop bundle production asset cleanup."
find ./apps/desktop/web-build -type f \( \
-name '*.css.map' -o \
-name '*.js.map' -o \
-name '*.LICENSE.txt' \
\) -print -delete
if find ./apps/desktop/web-build -type f \( \
-name '*.css.map' -o \
-name '*.js.map' -o \
-name '*.LICENSE.txt' \
\) -print -quit | grep -q .; then
echo "::error::Legacy desktop bundle production asset cleanup left sourcemap or license files behind."
exit 1
fi
fi

- name: bundle folder
run: |
Expand Down
Loading