Skip to content
This repository was archived by the owner on Oct 1, 2025. It is now read-only.

feat: ignore document store issued fragment for self signed document#93

Open
Nebulis wants to merge 1 commit intomasterfrom
feat/allow-proof-with-store
Open

feat: ignore document store issued fragment for self signed document#93
Nebulis wants to merge 1 commit intomasterfrom
feat/allow-proof-with-store

Conversation

@Nebulis
Copy link
Contributor

@Nebulis Nebulis commented Jun 3, 2020

@yehjxraymond @AdamJLemmon

First MR that skips OpenAttestationEthereumDocumentStoreIssued when the document contains a proof block.

Note that this detection only works for v2 document. V3 document being aligned on W#C VC will always have a proof block and thus we will need to check on the type of the proof instead

@AdamJLemmon
Copy link
Contributor

This looks good to me @Nebulis

Simple enough, if it is signed.. skip. This should allow us to immediately use a documentStore for only revocation :)

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants