Skip to content

docs(spec): unified agent panel 2d implementation plan#208

Merged
BunsDev merged 1 commit into
mainfrom
docs/unified-agent-panel-2d-plan
Jul 18, 2026
Merged

docs(spec): unified agent panel 2d implementation plan#208
BunsDev merged 1 commit into
mainfrom
docs/unified-agent-panel-2d-plan

Conversation

@BunsDev

@BunsDev BunsDev commented Jul 18, 2026

Copy link
Copy Markdown
Member

Description

Docs-only. The 2d implementation plan for the unified agent panel — specs/castcodes-unified-agent-panel/PLAN-2d.md. The final Phase 2 sub-phase: make the unified panel the default entry point and retire the two surfaces it replaces. Continues #204; builds on 2a (#205, merged) + 2b (#206) + 2c (#207).

2d scope (staged — flag first, delete after parity):

  1. Parity checklist gate before any deletion.
  2. Default-enable UnifiedAgentPanel and gate the old daemon surface off when it's on (reversible).
  3. Delete cli_chat::ChatPanelView + its panel wiring — keeping the whole cli_chat model layer (reused by agent_panel) and the shared OpenChatSession/CliChatNewChat actions.
  4. Remove the ai_assistant coven-stream section — the Familiar panel stays; coven_entry.rs + coven_stream_persist.rs are preserved (reused by 2c/2a).

Scoped from a full code survey: exact deletable symbols + line ranges, exact keep-list, and the enabled_features() flag-default mechanism. Deletions are gated behind parity + a reversible flag flip, with the compiler as the safety net.

Linked Issue

Completes the Phase 2 reconciliation roadmap (design #204; 2a #205; 2b #206; 2c #207; Phase 1 #201). No separate tracking issue, per the #204 precedent.

Testing

  • Docs-only. ./script/check_ai_attribution + ./script/check_rebrand pass.
  • Not manually run with ./script/run (n/a — plan document).

Agent Mode

@BunsDev

BunsDev commented Jul 18, 2026

Copy link
Copy Markdown
Member Author

Correction to PLAN-2d Task 4 (surfaced during stage-2 implementation, #214):

The plan assumes removing the ai_assistant coven-stream section leaves a functional Familiar panel (editor/requests/suggestions). That premise is wrong for this fork: under #[cfg(feature = "cast-agent")], AIAssistantPanelView::issue_primary_request routes every prompt through send_via_coven_gateway (panel.rs) — the coven-stream is the Familiar panel's entire agent path; there is no non-coven agent path (the inherited hosted path is stubbed, 501 Not Implemented).

So Task 4 is not "trim a section" — it retires the Familiar agent panel wholesale. That's a larger product decision than the plan captured and should be its own scoped PR + sign-off, not bundled with the (clean) cli_chat-panel retirement.

Stage-2 PR #214 therefore lands Task 3 only (retire cli_chat::ChatPanelView), and leaves Task 4 for a separate decision. Recommend revising PLAN-2d Task 4 accordingly.

@BunsDev
BunsDev marked this pull request as ready for review July 18, 2026 13:21
Copilot AI review requested due to automatic review settings July 18, 2026 13:21
@BunsDev
BunsDev merged commit 7fb3b99 into main Jul 18, 2026
18 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@BunsDev
BunsDev deleted the docs/unified-agent-panel-2d-plan branch July 18, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants