docs(spec): revised 2d Task 4 — retire the Familiar agent panel#215
Merged
Conversation
5 tasks
BunsDev
marked this pull request as ready for review
July 18, 2026 13:21
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a revised 2d Task 4 implementation plan that corrects the earlier premise and scopes the work as a full retirement of the Familiar (ai_assistant) panel, while explicitly preserving app-wide ai_assistant surfaces that are still depended on elsewhere.
Changes:
- Introduces a new plan doc that re-frames “remove coven-stream section” into whole-panel retirement with a compiler-driven unwire → delete workflow.
- Adds an explicit load-bearing gating decision (avoid leaving builds with no agent surface) as a prerequisite before any deletions.
- Documents a pinned delete/keep boundary and the expected workspace wiring removals + test/fixture cleanup steps.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+61
to
+62
| grep -rn "ai_assistant::requests\|ai_assistant::transcript\|Requests\b\|Transcript::new" app/src \ | ||
| | grep -v "app/src/ai_assistant/" |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Docs-only. The revised 2d Task 4 plan —
specs/castcodes-unified-agent-panel/PLAN-2d-task4-familiar-retirement.md. Supersedes the original PLAN-2d Task 4, whose premise was wrong (flagged on #208).Why revised: the original assumed removing the
ai_assistantcoven-stream was a section trim leaving a working Familiar panel. Investigation (during #214) showed that undercast-agent, the Familiar panel's entire submit path routes throughsend_via_coven_gateway— the coven-stream is its agent function; the non-coven parts (requests_model/transcript_view) are the dead Warp-hosted path (requests.rs: "TODO: Delete all of this once agent mode fully replaces the AI assistant panel"). So this is a whole-panel retirement.Plan highlights:
unified_agent_panelenabled — so the unified panel must be defaulted (or the retirement gated) first. The plan blocks until this is resolved.panel.rs+ the deadrequests.rs/transcript.rs+ the orphanedcoven_stream_persist.rs, unwire from the workspace, fix fixtures/tests.ai_assistantsurface used app-wide:AskAIType,execution_context::WarpAiExecutionContext,coven_entry::daemon_event_to_entry,AI_ASSISTANT_*constants (used across terminal/pane_group/ai/*).Linked Issue
Revises PLAN-2d Task 4 (#208); follows the cli_chat-panel retirement (#214). Roadmap: design #204; 2a #205, 2b #209, 2c #210, 2d stage-1 #213.
Testing
./script/check_ai_attribution+./script/check_rebrandpass.Agent Mode