Skip to content

docs(spec): revised 2d Task 4 — retire the Familiar agent panel#215

Merged
BunsDev merged 1 commit into
mainfrom
docs/familiar-panel-retirement-plan
Jul 18, 2026
Merged

docs(spec): revised 2d Task 4 — retire the Familiar agent panel#215
BunsDev merged 1 commit into
mainfrom
docs/familiar-panel-retirement-plan

Conversation

@BunsDev

@BunsDev BunsDev commented Jul 18, 2026

Copy link
Copy Markdown
Member

Description

Docs-only. The revised 2d Task 4 planspecs/castcodes-unified-agent-panel/PLAN-2d-task4-familiar-retirement.md. Supersedes the original PLAN-2d Task 4, whose premise was wrong (flagged on #208).

Why revised: the original assumed removing the ai_assistant coven-stream was a section trim leaving a working Familiar panel. Investigation (during #214) showed that under cast-agent, the Familiar panel's entire submit path routes through send_via_coven_gateway — the coven-stream is its agent function; the non-coven parts (requests_model/transcript_view) are the dead Warp-hosted path (requests.rs: "TODO: Delete all of this once agent mode fully replaces the AI assistant panel"). So this is a whole-panel retirement.

Plan highlights:

  • A load-bearing gating decision up front (prerequisite 3): retiring the Familiar panel strands users who have neither Agent Mode nor unified_agent_panel enabled — so the unified panel must be defaulted (or the retirement gated) first. The plan blocks until this is resolved.
  • Delete panel.rs + the dead requests.rs/transcript.rs + the orphaned coven_stream_persist.rs, unwire from the workspace, fix fixtures/tests.
  • Preserve the shared ai_assistant surface used app-wide: AskAIType, execution_context::WarpAiExecutionContext, coven_entry::daemon_event_to_entry, AI_ASSISTANT_* constants (used across terminal/pane_group/ai/*).
  • Compiler-driven ordering (unwire → delete), grep-pinned delete/keep boundary, both flag configs gated.

Linked Issue

Revises PLAN-2d Task 4 (#208); follows the cli_chat-panel retirement (#214). Roadmap: design #204; 2a #205, 2b #209, 2c #210, 2d stage-1 #213.

Testing

  • Docs-only. ./script/check_ai_attribution + ./script/check_rebrand pass.

Agent Mode

@BunsDev
BunsDev marked this pull request as ready for review July 18, 2026 13:21
Copilot AI review requested due to automatic review settings July 18, 2026 13:21
@BunsDev
BunsDev merged commit 3352e75 into main Jul 18, 2026
18 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a revised 2d Task 4 implementation plan that corrects the earlier premise and scopes the work as a full retirement of the Familiar (ai_assistant) panel, while explicitly preserving app-wide ai_assistant surfaces that are still depended on elsewhere.

Changes:

  • Introduces a new plan doc that re-frames “remove coven-stream section” into whole-panel retirement with a compiler-driven unwire → delete workflow.
  • Adds an explicit load-bearing gating decision (avoid leaving builds with no agent surface) as a prerequisite before any deletions.
  • Documents a pinned delete/keep boundary and the expected workspace wiring removals + test/fixture cleanup steps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +61 to +62
grep -rn "ai_assistant::requests\|ai_assistant::transcript\|Requests\b\|Transcript::new" app/src \
| grep -v "app/src/ai_assistant/"
@BunsDev
BunsDev deleted the docs/familiar-panel-retirement-plan branch July 18, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants