Skip to content

docs(acp): clarify mcp_config is a shared field, not ACP-only#197

Closed
simonrosenberg wants to merge 1 commit into
mainfrom
feat-acp-mcp
Closed

docs(acp): clarify mcp_config is a shared field, not ACP-only#197
simonrosenberg wants to merge 1 commit into
mainfrom
feat-acp-mcp

Conversation

@simonrosenberg
Copy link
Copy Markdown
Member

What

ACPAgentSettings now accepts mcp_config (the SDK forwards its MCP servers to the ACP subprocess at session creation — see OpenHands/software-agent-sdk#3458).

This clarifies on ACP_SETTINGS_KEYS that mcp_config is deliberately excluded from this ACP-exclusive allow-list.

Why

ACP_SETTINGS_KEYS is used to (a) copy ACP-only fields into an ACP payload and (b) strip them when switching to a non-ACP variant. mcp_config is shared with the OpenHands variant — adding it here would cause clients to delete mcp_config when switching agent kinds (and, in the agent-canvas adapter, would strip it right after the OpenHands builder preserved it). It must be handled per-variant like llm / agent_context, not stripped.

Comment-only change. tsc build + prettier + eslint clean.

Part of OpenHands/agent-canvas#993.

🤖 Generated with Claude Code

ACPAgentSettings now accepts mcp_config (its MCP servers are forwarded to the
ACP subprocess at session creation — see software-agent-sdk). Document on
ACP_SETTINGS_KEYS that mcp_config is deliberately excluded from this
ACP-exclusive allow-list: it is shared with the OpenHands agent variant, so
clients must handle it per-variant (like llm/agent_context) rather than
stripping it when switching agent kinds.

Part of OpenHands/agent-canvas#993.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@simonrosenberg
Copy link
Copy Markdown
Member Author

Closing as unnecessary. This was a comment-only clarification on ACP_SETTINGS_KEYS, but that constant is only re-exported from this package (not used internally), and its one consumer (agent-canvas) keeps its own local copy. The useful insight — mcp_config is a shared field, not ACP-only, so it must not be stripped on agent-kind switches — is already captured where it matters in the SDK and agent-canvas changes.

The ACP-MCP feature ships fully via OpenHands/software-agent-sdk#3458 + OpenHands/agent-canvas#995; neither depends on this. No code change is needed here.

@simonrosenberg simonrosenberg deleted the feat-acp-mcp branch June 1, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant