docs(acp): clarify mcp_config is a shared field, not ACP-only#197
Closed
simonrosenberg wants to merge 1 commit into
Closed
docs(acp): clarify mcp_config is a shared field, not ACP-only#197simonrosenberg wants to merge 1 commit into
simonrosenberg wants to merge 1 commit into
Conversation
ACPAgentSettings now accepts mcp_config (its MCP servers are forwarded to the ACP subprocess at session creation — see software-agent-sdk). Document on ACP_SETTINGS_KEYS that mcp_config is deliberately excluded from this ACP-exclusive allow-list: it is shared with the OpenHands agent variant, so clients must handle it per-variant (like llm/agent_context) rather than stripping it when switching agent kinds. Part of OpenHands/agent-canvas#993. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
Closing as unnecessary. This was a comment-only clarification on The ACP-MCP feature ships fully via OpenHands/software-agent-sdk#3458 + OpenHands/agent-canvas#995; neither depends on this. No code change is needed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ACPAgentSettingsnow acceptsmcp_config(the SDK forwards its MCP servers to the ACP subprocess at session creation — see OpenHands/software-agent-sdk#3458).This clarifies on
ACP_SETTINGS_KEYSthatmcp_configis deliberately excluded from this ACP-exclusive allow-list.Why
ACP_SETTINGS_KEYSis used to (a) copy ACP-only fields into an ACP payload and (b) strip them when switching to a non-ACP variant.mcp_configis shared with the OpenHands variant — adding it here would cause clients to deletemcp_configwhen switching agent kinds (and, in the agent-canvas adapter, would strip it right after the OpenHands builder preserved it). It must be handled per-variant likellm/agent_context, not stripped.Comment-only change.
tscbuild + prettier + eslint clean.Part of OpenHands/agent-canvas#993.
🤖 Generated with Claude Code