Skip to content

docs(acp): clarify mcp_config is a shared field, not ACP-only #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simonrosenberg wants to merge 1 commit into from
Closed

docs(acp): clarify mcp_config is a shared field, not ACP-only #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/models/acp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,16 @@ export function getAcpProvider(key: string | null | undefined): ACPProviderInfo
}

/**
* Allow-list of fields that travel on an `ACPAgent` settings payload.
* Mirrors `openhands.sdk.settings.model.ACPAgentSettings`'s field set.
* Clients filter ACP-only fields out when switching to a non-ACP variant.
* Allow-list of the `acp_*`-prefixed fields that travel on an `ACPAgent`
* settings payload. Mirrors `openhands.sdk.settings.model.ACPAgentSettings`'s
* ACP-exclusive field set. Clients filter these out when switching to a
* non-ACP variant.
*
* Deliberately excludes `mcp_config`: it is also a valid `ACPAgent` field (its
* MCP servers are forwarded to the ACP subprocess at session creation), but it
* is **shared** with the OpenHands agent variant — so it must NOT be stripped
* when switching agent kinds. Treat `mcp_config` like `llm`/`agent_context`
* (shared, handled explicitly per variant), not as an ACP-only field.
*/
export const ACP_SETTINGS_KEYS: readonly string[] = [
'acp_command',
Expand Down
Loading