Skip to content

fix: replace 'Director of Football' with 'General Manager' - #322

Open
TtvNekix wants to merge 2 commits into
OpenLeagueManager:developfrom
TtvNekix:fix/lol-terminology
Open

fix: replace 'Director of Football' with 'General Manager'#322
TtvNekix wants to merge 2 commits into
OpenLeagueManager:developfrom
TtvNekix:fix/lol-terminology

Conversation

@TtvNekix

Copy link
Copy Markdown
Contributor

Summary

Replaced all remaining "Director of Football" references with "General Manager" (esports-appropriate terminology).

Changes

Rust Backend

  • contracts.rs, transfers.rs: added missing with_sender_i18n()
  • messages/mod.rs: updated role string
  • All use "General Manager" instead of "Director of Football"

i18n (8 locales)

  • Renamed key directorOfFootball -> generalManager
  • Updated translations across en, es, fr, de, it, pt, pt-BR, tr

Tests

  • Updated assertions in messages_tests.rs and random_events_tests.rs

TtvNekix added 2 commits June 13, 2026 03:32
- Changed all Rust backend code from 'Director of Football' to 'General Manager'
- Added missing .with_sender_i18n() calls in contracts.rs and transfers.rs
- Updated i18n keys from 'directorOfFootball' to 'generalManager'
- Updated all 8 locale files (en, es, fr, de, it, pt, pt-BR, tr)
- Updated test assertions
- Updated docs/_DASHBOARD_MESSAGES.md with new sender id/name/role
- No remaining frontend references to directorOfFootball found in src/
- Internal legacy migration code (countries.ts, sql files) kept as-is for historical context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant