Skip to content

refactor(domain): migrate TeamSeasonRecord to LoL (remove draws) - #68

Merged
aalonsolopez merged 3 commits into
OpenLeagueManager:developfrom
NicoRuedaA:feat/53-remove-draws-team-season-record
May 1, 2026
Merged

refactor(domain): migrate TeamSeasonRecord to LoL (remove draws)#68
aalonsolopez merged 3 commits into
OpenLeagueManager:developfrom
NicoRuedaA:feat/53-remove-draws-team-season-record

Conversation

@NicoRuedaA

Copy link
Copy Markdown
Contributor

Summary

  • Removed draws field from TeamSeasonRecord struct since LoL matches have no draws
  • Updated all places where TeamSeasonRecord is created (turn/mod.rs, end_of_season.rs)
  • Updated points calculation to reflect win-only scoring (3 points per win)
  • Updated related tests to remove references to draws

Changes

  • team.rs: Removed drawn: u32 from struct definition
  • turn/mod.rs: Updated struct initialization and points calculation
  • end_of_season.rs: Updated struct initialization when recording season history
  • end_of_season_tests.rs: Removed test assertion for draws
  • team_repo.rs: Updated test fixture

Testing

  • cargo check passes

Refs: #53

@NicoRuedaA
NicoRuedaA force-pushed the feat/53-remove-draws-team-season-record branch from 91a401d to 85d9155 Compare April 30, 2026 22:41
@NicoRuedaA

Copy link
Copy Markdown
Contributor Author

Original Issue: #53

@aalonsolopez
aalonsolopez changed the base branch from main to develop April 30, 2026 23:23
@aalonsolopez
aalonsolopez merged commit ae9ecf3 into OpenLeagueManager:develop May 1, 2026
4 checks passed
@NicoRuedaA
NicoRuedaA deleted the feat/53-remove-draws-team-season-record branch May 7, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants