Skip to content

chore: superseded Phase E workflow installation - #1381

Closed
Brad-Edwards wants to merge 2 commits into
devfrom
1380-install-phase-e-workflow
Closed

Brad-Edwards wants to merge 2 commits into
devfrom
1380-install-phase-e-workflow

Conversation

@Brad-Edwards

@Brad-Edwards Brad-Edwards commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Superseded by merged PR #1379. After merging current dev, this PR has zero changed files. The original failed checks belong to the old head; GitHub registered no CI run for the empty current head.

Ground Control cannot record delivery readiness because its Phase E workflow is absent from dev. Install the exact official consumer workflow so subsequent merged deliveries can validate merged requirement state, publish their final report and close their issue.

Requirement UIDs

  • (none — bug/refactor/maintenance run; see Traceability section below)

Related Issues

Closes #1380

ADR Impact

  • ADR-021 (Ground Control delivery workflow; no repository ADR amendment)

Changes

  • Install the official grndctl 1.2.1 consumer workflow with pinned action revisions and merged-PR or maintainer-dispatch triggers.
  • Read the immutable merge revision with checkout credential persistence disabled; grant only issues write access for final reports and issue closure.
  • Bootstrap dependency: merge this workflow into dev before retrying readiness for PR docs: define control applicability and effect decisions #1378. This PR cannot record its own pre-merge handoff while the workflow is absent from its base. The broader package-adoption issue Adopt Ground Control from the published grndctl package #1377 remains open.

Test Plan

  • Unit tests pass
  • Integration tests pass if applicable
  • Full completion suite required in CI before merge
  • No coverage regression

Passed YAML parsing and assertions for trigger gating, least-privilege permissions, pinned actions/package, merge-revision checkout, credential persistence and per-PR concurrency. Targeted file-local policy and requirement-governance checks passed, as did the mandatory pre-commit boundary. Hosted checks run on this PR; the first post-merge execution verifies integration with GitHub Actions. Operational setup only; inline comments document its triggers, trust boundaries and repair dispatch.

Ground Control Checks

  • Repository policy checks required in CI before merge
  • Pre-push Codex review not run for this lane; CI and repository policy gates enforced

Traceability

  • IMPLEMENTS: .github/workflows/ground-control-phase-e.yml (repository delivery setup; no product requirement)
  • TESTS: Targeted workflow structure/security assertions and file-local policy/governance checks.

Checklist

  • Code follows the project's coding standards
  • Changelog: owned by Release Please (generated from the Conventional Commit PR title; no per-PR fragment)
  • Architectural docs updated if stack, package structure, or key behaviors changed

Documentation

Verified unchanged: no documentation surface in scope.

@Brad-Edwards Brad-Edwards changed the title ci: install Ground Control Phase E finalization chore: superseded Phase E workflow installation Sep 23, 2026
@Brad-Edwards
Brad-Edwards marked this pull request as ready for review September 23, 2026 23:52
@Brad-Edwards
Brad-Edwards deleted the 1380-install-phase-e-workflow branch September 23, 2026 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant