Repository navigation
Refuse a column mapping table to a client that did not advertise it - #197
Merged
Merged
Conversation
littlegrasscao
requested review from
chakankardb,
hueyhuilonghan and
linzhou-db
as code owners
November 13, 2026 03:08
This was referenced Nov 13, 2026
Closed
|
🔍 OpenCodeReview found 1 issue(s) in this PR.
📄
|
littlegrasscao
force-pushed
the
fix/unsupported-table-properties
branch
from
November 13, 2026 04:34
b3f2e76 to
781378f
Compare
littlegrasscao
force-pushed
the
fix/unsupported-table-properties
branch
from
November 13, 2026 04:53
781378f to
db414e4
Compare
littlegrasscao
force-pushed
the
fix/unsupported-table-properties
branch
from
November 13, 2026 05:08
db414e4 to
6899846
Compare
littlegrasscao
force-pushed
the
fix/unsupported-table-properties
branch
2 times, most recently
from
November 13, 2026 05:20
dff930f to
ce64b63
Compare
littlegrasscao
force-pushed
the
fix/unsupported-table-properties
branch
from
November 13, 2026 05:41
ce64b63 to
0b571f3
Compare
littlegrasscao
force-pushed
the
fix/unsupported-table-properties
branch
from
November 13, 2026 05:51
0b571f3 to
41292e0
Compare
littlegrasscao
force-pushed
the
fix/unsupported-table-properties
branch
from
November 13, 2026 05:58
41292e0 to
1a7de13
Compare
littlegrasscao
force-pushed
the
fix/unsupported-table-properties
branch
from
November 13, 2026 07:18
1a7de13 to
a23e0de
Compare
littlegrasscao
force-pushed
the
fix/unsupported-table-properties
branch
from
November 13, 2026 07:50
a23e0de to
9c1531c
Compare
littlegrasscao
force-pushed
the
fix/unsupported-table-properties
branch
from
November 13, 2026 17:10
9c1531c to
7307593
Compare
littlegrasscao
force-pushed
the
fix/unsupported-table-properties
branch
from
November 13, 2026 17:38
7307593 to
d14155b
Compare
1 task done
zhu-tom
approved these changes
Nov 13, 2026
littlegrasscao
force-pushed
the
fix/unsupported-table-properties
branch
3 times, most recently
from
November 13, 2026 21:54
ff85475 to
ab56192
Compare
A table whose delta.columnMapping.mode is on cannot be served to a client whose delta-sharing-capabilities do not list the columnmapping reader feature, whatever the table's protocol lists: the property decides. The query is rejected with the table feature named, instead of being answered in a format the client cannot read. Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: Sun Cao <sun.cao+data@databricks.com>
littlegrasscao
force-pushed
the
fix/unsupported-table-properties
branch
from
November 16, 2026 17:50
ab56192 to
51088ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #196.
A table whose
delta.columnMapping.modeis on was answered in delta format to a client that had not advertised thecolumnmappingreader feature, which that client cannot read. The property decides, whatever the protocol lists, as in Delta Sharing:delta.columnMapping.modeis notnoneand the client did not advertisecolumnmappingINVALID_PARAMETER_VALUE"Table features delta.columnMapping.mode are found in table version:<n>."DeltaSharingCapabilities.requireColumnMappingSupportruns on snapshot queries./metadatadoes not check it, so clients can inspect a table before querying files.Test plan
mvn -pl opensharing-server-core,opensharing-server clean test(Java 17) passes.This pull request and its description were written by Isaac.