Skip to content

Refuse a column mapping table to a client that did not advertise it - #197

Merged
littlegrasscao merged 1 commit into
mainfrom
fix/unsupported-table-properties
Nov 16, 2026
Merged

littlegrasscao merged 1 commit into
mainfrom
fix/unsupported-table-properties

Conversation

@littlegrasscao

@littlegrasscao littlegrasscao commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Depends on #196.

A table whose delta.columnMapping.mode is on was answered in delta format to a client that had not advertised the columnmapping reader feature, which that client cannot read. The property decides, whatever the protocol lists, as in Delta Sharing:

Case Answer
delta.columnMapping.mode is not none and the client did not advertise columnmapping 400 INVALID_PARAMETER_VALUE "Table features delta.columnMapping.mode are found in table version: <n>."

DeltaSharingCapabilities.requireColumnMappingSupport runs on snapshot queries. /metadata does not check it, so clients can inspect a table before querying files.

Test plan

  • mvn -pl opensharing-server-core,opensharing-server clean test (Java 17) passes.

This pull request and its description were written by Isaac.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

🔍 OpenCodeReview found 1 issue(s) in this PR.

  • ✅ Successfully posted inline: 0 comment(s)
  • ❌ Failed to post inline: 1 comment(s)

bug · medium

📄 server/opensharing-server-core/src/main/java/io/opensharing/asset/table/delta/DeltaTableQueryReader.java (L333-L333)

⚠️ GitHub could not post this as an inline comment: Line 333 could not be resolved (outside PR diff hunks)

The column-mapping check is added only to the snapshot query. The changes/CDF path (here, and the other requireReaderFeatures call sites) still serves column-mapped tables to clients that did not advertise columnmapping, as long as the protocol check passes. Apply requireColumnMappingSupport there too, using the metadata of the relevant version. The new check also has no tests.

@littlegrasscao
littlegrasscao force-pushed the fix/unsupported-table-properties branch from b3f2e76 to 781378f Compare November 13, 2026 04:34
@littlegrasscao
littlegrasscao force-pushed the fix/unsupported-table-properties branch from 781378f to db414e4 Compare November 13, 2026 04:53
@littlegrasscao
littlegrasscao force-pushed the fix/unsupported-table-properties branch from db414e4 to 6899846 Compare November 13, 2026 05:08
@littlegrasscao
littlegrasscao force-pushed the fix/unsupported-table-properties branch 2 times, most recently from dff930f to ce64b63 Compare November 13, 2026 05:20
@littlegrasscao
littlegrasscao force-pushed the fix/unsupported-table-properties branch from ce64b63 to 0b571f3 Compare November 13, 2026 05:41
@littlegrasscao littlegrasscao changed the title Refuse tables whose Delta properties the client did not advertise Refuse tables whose Delta properties or reader features the client did not advertise Nov 13, 2026
@littlegrasscao
littlegrasscao force-pushed the fix/unsupported-table-properties branch from 0b571f3 to 41292e0 Compare November 13, 2026 05:51
@littlegrasscao
littlegrasscao force-pushed the fix/unsupported-table-properties branch from 41292e0 to 1a7de13 Compare November 13, 2026 05:58
@littlegrasscao
littlegrasscao force-pushed the fix/unsupported-table-properties branch from 1a7de13 to a23e0de Compare November 13, 2026 07:18
@littlegrasscao littlegrasscao changed the title Refuse tables whose Delta properties or reader features the client did not advertise Refuse a column mapping table to a client that did not advertise it Nov 13, 2026
@littlegrasscao
littlegrasscao force-pushed the fix/unsupported-table-properties branch from a23e0de to 9c1531c Compare November 13, 2026 07:50
@littlegrasscao
littlegrasscao force-pushed the fix/unsupported-table-properties branch from 9c1531c to 7307593 Compare November 13, 2026 17:10
@littlegrasscao
littlegrasscao force-pushed the fix/unsupported-table-properties branch from 7307593 to d14155b Compare November 13, 2026 17:38
@littlegrasscao littlegrasscao mentioned this pull request Nov 13, 2026
1 task done
@littlegrasscao
littlegrasscao force-pushed the fix/unsupported-table-properties branch 3 times, most recently from ff85475 to ab56192 Compare November 13, 2026 21:54
Base automatically changed from fix/error-validation-messages to main November 16, 2026 17:50
A table whose delta.columnMapping.mode is on cannot be served to a client
whose delta-sharing-capabilities do not list the columnmapping reader
feature, whatever the table's protocol lists: the property decides. The
query is rejected with the table feature named, instead of being answered
in a format the client cannot read.

Co-authored-by: Isaac <no-reply@databricks.com>
Signed-off-by: Sun Cao <sun.cao+data@databricks.com>
@littlegrasscao
littlegrasscao force-pushed the fix/unsupported-table-properties branch from ab56192 to 51088ff Compare November 16, 2026 17:50
@littlegrasscao
littlegrasscao merged commit e769415 into main Nov 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants