Repository navigation
Answer a missing or invalid shared-table Delta log with errors that name the data provider - #186
Closed
littlegrasscao wants to merge 1 commit into
Closed
littlegrasscao wants to merge 1 commit into
littlegrasscao wants to merge 1 commit into
Conversation
littlegrasscao
requested review from
chakankardb,
hueyhuilonghan and
linzhou-db
as code owners
November 12, 2026 21:58
|
🔍 OpenCodeReview found 2 issue(s) in this PR.
📄
|
2 tasks done
littlegrasscao
force-pushed
the
fix/incomplete-delta-log-catalog-error
branch
from
November 13, 2026 01:31
fc682a9 to
afade93
Compare
littlegrasscao
force-pushed
the
fix/incomplete-delta-log-catalog-error
branch
from
November 13, 2026 01:39
afade93 to
03f45df
Compare
littlegrasscao
force-pushed
the
fix/incomplete-delta-log-catalog-error
branch
from
November 13, 2026 01:47
03f45df to
add54a7
Compare
littlegrasscao
force-pushed
the
fix/incomplete-delta-log-catalog-error
branch
from
November 13, 2026 01:57
add54a7 to
0b96d5f
Compare
3 tasks done
…ame the data provider A shared table whose Delta log is missing, starts after version 0, has a gap, or is otherwise invalid, or whose version Kernel cannot read, returned 500 INTERNAL_ERROR or an error code and message of this server's own. The recipient cannot fix any of these, so the answer now says what is wrong and, when the shared table itself is at fault, whom to contact. DeltaKernel classifies every Kernel failure once, by Kernel's exception type rather than its message text: - A missing log (TableNotFoundException), or a file that is missing or denied (FileNotFoundException, AccessDeniedException), is the shared table's own state: 400 BAD_REQUEST "Unable to access table <share>.<schema>.<table>: something is wrong with the table. Please contact your data provider." The table is named as the share names it, and its storage path stays in the log. - An InvalidTableException, such as a gap in the log, is reported in Kernel's own words, with every spelling of the table's path and any other location removed, and the recipient is asked to contact the data provider: 400 BAD_REQUEST. - Any other Kernel report, such as a version or timestamp the table does not have, is the request's mistake in Kernel's words, without the path: 400 BAD_REQUEST. - A failure of the storage layer for a reason of its own stays a server error. - A reader feature or version Kernel cannot read is named in a fixed order: 400 INVALID_PARAMETER_VALUE "Table features <features> are found in table[ version: <n>]. This server cannot read them. Please contact your data provider." The version endpoint no longer pre-checks a timestamp against the latest commit and leaves that to Kernel, and a snapshot is opened straight at the version or timestamp asked for. Adds ErrorCodes.BAD_REQUEST, ApiException.badRequest and ApiException.unsupportedFeatures, and fixtures for a log with in-commit timestamps but no CommitInfo (in a directory with a space in its name) and a table that is readable at its latest version but not at version 0. Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: Sun Cao <sun.cao+data@databricks.com>
littlegrasscao
force-pushed
the
fix/incomplete-delta-log-catalog-error
branch
from
November 13, 2026 02:02
0b96d5f to
5922607
Compare
This was referenced Nov 13, 2026
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A shared table whose Delta log is missing, starts after version 0, has a gap, or is otherwise invalid, or whose version Kernel cannot read, returned 500
INTERNAL_ERRORor an error code and message of this server's own. The recipient cannot fix any of these, so the answer now says what is wrong and, when the shared table itself is at fault, whom to contact. Storage paths stay in the server log and out of every response.DeltaKernel.classifyclassifies each Kernel failure once, by exception type instead of message text:TableNotFoundException), or a file missing or denied (FileNotFoundException,AccessDeniedException)BAD_REQUEST"Unable to access table<share>.<schema>.<table>: something is wrong with the table. Please contact your data provider."InvalidTableException(gap, non-contiguous, invalid content)BAD_REQUEST, Kernel's message with the table path removed, then " Please contact your data provider."BAD_REQUEST, Kernel's message with the table path removedINVALID_PARAMETER_VALUE"Table features<features>are found in table[ version:<n>]. This server cannot read them. Please contact your data provider." (features lowercase, sorted)Path removal replaces every spelling of the table path (as given, without
file:, with spaces escaped or not) and then any other location with a scheme.The version endpoint no longer pre-checks a timestamp against the latest commit, and snapshots are opened straight at the version or timestamp asked for; Kernel's message is what the recipient gets.
Fixes #185
Changes
ErrorCodes.BAD_REQUEST,ApiException.badRequest,ApiException.unsupportedFeatures; the 400RESOURCE_DOES_NOT_EXISTfactories are gone.SourceTableExceptioncarries a source-table failure up toProtocolTables, which names the table as the share does.DeltaKernel,DeltaSnapshots, the readers).Test plan
opensharing-server-coreandopensharing-servertest runs pass locally (Java 17, Maven). S3-backed integration classes skip without cloud credentials; their expectations were updated but not run.This pull request and its description were written by Isaac.