Repository navigation
Relay Kernel's report on a version, timestamp, or log it cannot read - #195
Merged
Merged
Conversation
littlegrasscao
requested review from
chakankardb,
hueyhuilonghan and
linzhou-db
as code owners
November 13, 2026 03:08
This was referenced Nov 13, 2026
This was referenced Nov 13, 2026
Closed
|
🔍 OpenCodeReview found 3 issue(s) in this PR.
ℹ️ All inline comments overlapped with existing reviews; nothing new was posted. |
littlegrasscao
force-pushed
the
fix/incomplete-delta-log-catalog-error
branch
from
November 13, 2026 04:34
5922607 to
b449678
Compare
littlegrasscao
force-pushed
the
fix/incomplete-delta-log-catalog-error
branch
2 times, most recently
from
November 13, 2026 05:08
c956d68 to
616ca34
Compare
littlegrasscao
force-pushed
the
fix/incomplete-delta-log-catalog-error
branch
from
November 13, 2026 05:20
616ca34 to
a15be76
Compare
littlegrasscao
force-pushed
the
fix/incomplete-delta-log-catalog-error
branch
from
November 13, 2026 05:41
a15be76 to
8132582
Compare
littlegrasscao
force-pushed
the
fix/incomplete-delta-log-catalog-error
branch
from
November 13, 2026 05:51
8132582 to
fcd5e7a
Compare
littlegrasscao
force-pushed
the
fix/incomplete-delta-log-catalog-error
branch
2 times, most recently
from
November 13, 2026 07:18
92613ac to
a163a33
Compare
littlegrasscao
force-pushed
the
fix/incomplete-delta-log-catalog-error
branch
from
November 13, 2026 07:50
a163a33 to
5d176b1
Compare
littlegrasscao
force-pushed
the
fix/incomplete-delta-log-catalog-error
branch
from
November 13, 2026 17:10
5d176b1 to
d3af967
Compare
littlegrasscao
force-pushed
the
fix/incomplete-delta-log-catalog-error
branch
from
November 13, 2026 17:38
d3af967 to
c107c50
Compare
zhu-tom
approved these changes
Nov 13, 2026
A version, timestamp, or log that Delta Kernel rejects, such as a version after the latest, a timestamp before the first commit, or a missing log file, is answered with 400 BAD_REQUEST and Kernel's message, instead of the server's own wording for the cases it checked first. A version after the latest is answered with Kernel's message without asking Kernel: for a version far ahead, such as 999999, Kernel searches back through the log for a checkpoint, which takes minutes on object storage. Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: Sun Cao <sun.cao+data@databricks.com>
littlegrasscao
force-pushed
the
fix/incomplete-delta-log-catalog-error
branch
from
November 13, 2026 21:46
c107c50 to
b393ef0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A version, timestamp, or log that Delta Kernel rejects was answered with this server's own wording, or with 500
INTERNAL_ERRORfor a gapped or invalid log. Delta Sharing relays Kernel's report instead.BAD_REQUEST, Kernel's message as it isChange
ApiFailuremaps aKernelExceptionto 400BAD_REQUESTwith its message;ErrorCodes.BAD_REQUESTis new. Requests that fail after a response began use the same mapping.DeltaSnapshotsand the version endpoint no longer check a timestamp against the latest commit before asking Kernel, so Kernel's message is what the recipient gets. A protocol Kernel cannot read keeps its existing answer.Test plan
mvn -pl opensharing-server-core,opensharing-server clean test(Java 17) passes; cloud-gated integration classes need credentials, and their expectations were updated for CI.This pull request and its description were written by Isaac.