Repository navigation
Answer change data and request mistakes with specific errors - #196
Merged
Merged
Conversation
littlegrasscao
requested review from
chakankardb,
hueyhuilonghan and
linzhou-db
as code owners
November 13, 2026 03:08
1 task done
|
🔍 OpenCodeReview found 2 issue(s) in this PR.
|
littlegrasscao
force-pushed
the
fix/error-validation-messages
branch
from
November 13, 2026 04:34
0c9e105 to
47dfa91
Compare
littlegrasscao
force-pushed
the
fix/error-validation-messages
branch
from
November 13, 2026 04:53
47dfa91 to
a9dd4c4
Compare
littlegrasscao
force-pushed
the
fix/error-validation-messages
branch
from
November 13, 2026 05:08
a9dd4c4 to
87f1c48
Compare
littlegrasscao
force-pushed
the
fix/error-validation-messages
branch
from
November 13, 2026 05:20
87f1c48 to
f18253a
Compare
littlegrasscao
force-pushed
the
fix/error-validation-messages
branch
from
November 13, 2026 05:41
f18253a to
231fc1b
Compare
littlegrasscao
force-pushed
the
fix/error-validation-messages
branch
from
November 13, 2026 05:51
231fc1b to
0190e71
Compare
littlegrasscao
force-pushed
the
fix/error-validation-messages
branch
from
November 13, 2026 05:58
0190e71 to
5927e2f
Compare
littlegrasscao
force-pushed
the
fix/error-validation-messages
branch
from
November 13, 2026 07:18
5927e2f to
925cb39
Compare
littlegrasscao
force-pushed
the
fix/error-validation-messages
branch
from
November 13, 2026 07:50
925cb39 to
6ac8b02
Compare
littlegrasscao
force-pushed
the
fix/error-validation-messages
branch
from
November 13, 2026 17:10
6ac8b02 to
28f4cff
Compare
littlegrasscao
force-pushed
the
fix/error-validation-messages
branch
from
November 13, 2026 17:38
28f4cff to
cab4f56
Compare
zhu-tom
reviewed
Nov 13, 2026
littlegrasscao
force-pushed
the
fix/error-validation-messages
branch
from
November 13, 2026 21:46
cab4f56 to
2c17239
Compare
Base automatically changed from
fix/incomplete-delta-log-catalog-error
to
main
November 13, 2026 21:54
- A Change Data Feed range that reaches a version that did not record change data is answered 403 PERMISSION_DENIED, naming the table as the share does. When the response has already begun, the error ends it: in the endStreamAction with its status when the client asked for one, and otherwise in a line that is not JSON, so the client fails on it. - An endingTimestamp after the latest commit is rejected with the latest commit time to ask for instead. - version, timestamp and startingVersion are mutually exclusive, checked before any of them is parsed. - A Change Data Feed boundary is a version or a timestamp, not both: giving both a starting or both an ending one is rejected before the table is read. - A negative startingVersion, a range that ends before it starts, and a timestamp that is not ISO-8601 are rejected with specific messages. Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: Sun Cao <sun.cao+data@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: Sun Cao <sun.cao+data@databricks.com>
littlegrasscao
force-pushed
the
fix/error-validation-messages
branch
from
November 13, 2026 21:54
e91f5b7 to
39f6947
Compare
zhu-tom
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #195.
Change Data Feed failures and request mistakes that the client tests exercise are answered the way Delta Sharing answers them.
PERMISSION_DENIED"Unable to access change data feed for<share>.<schema>.<table>. CDF is not enabled on the original delta table for version<n>. Please contact your data provider."endStreamActioncarrying<ERRORCODE>: <message>andhttpStatusErrorCodefor a client that asked for one, and with a line that is not JSON, naming the error, otherwiseendingTimestampafter the latest commitINVALID_PARAMETER_VALUE"The provided timestamp(<ts>) is after the latest table version available to this table (<latest>). Please use a timestamp less than or equal to<latest>"version,timestamp,startingVersionin a query bodystartingVersion;startingVersionafterendingVersion<reason>."Change
ChangeDataNotRecordedExceptionis thrown by the reader;ProtocolTablesnames the table as the share does.NdjsonResponseends a stream that fails after it began with the error instead of aborting it;EndStreamActiongainshttpStatusErrorCode.DeltaTableQueryReaderchecksendingTimestampagainst the latest commit.startingVersionandstartingTimestamp, or bothendingVersionandendingTimestamp, is rejected with 400INVALID_PARAMETER_VALUE"Multiple<starting|ending>arguments provided for CDF read. Please provide one of either<starting|ending>Timestamp or<starting|ending>Version.", before the table is read.Test plan
mvn -pl opensharing-server-core,opensharing-server clean test(Java 17) passes; cloud-gated integration classes need credentials, and their expectations were updated for CI.This pull request and its description were written by Isaac.