fix(tsp-js): refuse an XSCS/XCTL body that is not exactly one Bytes primitive - #249
Merged
stormer78 merged 1 commit intoSep 16, 2026
Conversation
…rimitive Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR targets
feat/tsp-rev2-rev3-dual-handler, where Rev 3 lives; it isn't onmainyet.decodePayloadFrameread an XSCS/XCTL body as its first primitive. It dropped anything else in the-A##stream without an error and ignored data after the stream.The body must now be an
-A##stream that ends the payload frame and holds exactly one Bytes primitive. That is the form used by the spec's vectors and the ToIP reference (tsp_sdk0.11). Everything else throws: an-H##group, a second primitive, or trailing data.Context: tswg-tsp-specification#77. Found by the cross-implementation TSP Rev 3 conformance suite.
tests/payload.app-stream.mjscovers the single-primitive body and all three refusals.npm test: 110 pass.CHANGELOG.mdhas an Unreleased entry.