Added restriction of magical traditions to FamiliarsTrick#126
Merged
Conversation
elyukai
previously approved these changes
Mar 21, 2026
Collaborator
elyukai
left a comment
elyukai
left a comment
There was a problem hiding this comment.
Also prinzipiell sieht das gut aus! Wenn du traditions allerdings auf Required belässt und nicht auf Optional stellst, wäre es trotzdem noch ein Breaking Change, da dann bei allen Vertrautentricks ein leeres Array nachgetragen werden muss. Würde ich jetzt aber nicht als Problem sehen, da das ja genauso bei den Tierarten funktioniert.
Collaborator
Author
|
Wäre es dann sinnvoll die Tierarten, welche ja auch optional sind vielleicht auch als solche zu deklarieren. Dann hätten wir den breaking change raus und die Tierarten wären dann auch 'sauber` im schema dargestellt. Das bestehende leere array würde ja nicht weiter stören oder? |
elyukai
requested changes
Mar 22, 2026
Collaborator
elyukai
left a comment
elyukai
left a comment
There was a problem hiding this comment.
Noch eine Kleinigkeit, dann kann ich mergen.
elyukai
reviewed
Mar 23, 2026
elyukai
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #106