Skip to content

Added restriction of magical traditions to FamiliarsTrick #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elyukai merged 6 commits into from
Mar 23, 2026
+12 −2
Merged

Added restriction of magical traditions to FamiliarsTrick #126

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a8c32c8
Added restriction of magical traditions to FamiliarsTrick.ts
Lector Mar 20, 2026
d333189
formatted FamiliarsTrick.ts
Lector Mar 20, 2026
9be9409
FamiliarsTrick.ts -> Traditions is now optional
Lector Mar 21, 2026
30ff91a
MinItems for magical tradition restrictions of FamiliarsTrick.ts set …
Lector Mar 23, 2026
3f95124
Merge branch 'main' into feature/familiars-trick
elyukai Mar 23, 2026
c38cd52
Fix formatting
elyukai Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/types/FamiliarsTrick.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@ import {
FixedDuration,
IndefiniteDuration,
} from "./_ActivatableSkillDuration.js"
import { AnimalTypeIdentifier, PropertyIdentifier } from "./_Identifier.js"
import {
AnimalTypeIdentifier,
MagicalTraditionIdentifier,
PropertyIdentifier,
} from "./_Identifier.js"
import { ResponsiveText } from "./_ResponsiveText.js"
import { NestedTranslationMap } from "./Locale.js"
import { Errata } from "./source/_Erratum.js"
Expand All @@ -25,9 +29,15 @@ export const FamiliarsTrick = DB.Entity(import.meta.url, {
animal_types: DB.Required({
comment: `The animal types this trick is available to. Either it is available to all or only a list of specific animal types.

If no animal types are given, the animal disease applies to all animal types.`,
If no animal types are given, the familiars trick applies to all animal types.`,
type: DB.Array(AnimalTypeIdentifier(), { uniqueItems: true }),
}),
traditions: DB.Optional({
comment: `The magical traditions whose familiars can use this trick. Either it is available to all or only a list of specific traditions.

If no traditions are given, the familiars trick is not restricted by the magical tradition at all.`,
type: DB.Array(MagicalTraditionIdentifier(), { uniqueItems: true, minItems: 1 }),
}),
parameters: DB.Required({
comment: "Measurable parameters of a familiar’s trick.",
type: DB.IncludeIdentifier(FamiliarsTrickPerformanceParameters),
Expand Down
Loading