Show Archived Deployments#772
Conversation
…nt view that are hidden by default
…hem have not been deployed yet
…e view instead of just the latest version If the version is not yet deployed it is deployed automatically
This comment has been minimized.
This comment has been minimized.
…atic expansion in the left sidebar menu do not work anymore
This comment has been minimized.
This comment has been minimized.
| pathname + '?' + createQueryString('archived', el.target.checked ? 'true' : ''), | ||
| ) | ||
| } | ||
| > |
There was a problem hiding this comment.
since toggling the checkbox would cause a full server re-render via navigation. and if I have understood it correctly, the list will briefly show the old data while the server renders the new result. A loading indicator during the navigation would improve the user experience.
Since useTransition is already imported and used in this file, may be for this you can add a new transition and wrap the router.push in the checkbox onChange
There was a problem hiding this comment.
I've added a loading indicator to the checkbox and the table
| if (isUserErrorResponse(versions)) return []; | ||
|
|
||
| // filter out all versions that are not executable | ||
| versions = await asyncFilter(versions, async (version) => { |
There was a problem hiding this comment.
to be honest I am not sure whether I am right or not, or how much effort will it need to implement my suggestion. But fetching all version from db after every 1 second and then parsing it to BpmnObject seems very heavy and expensive (consider we have 7 versions of a large process).
so if I am not wrong then my suggestion is may be we can cash the result of each parse on first load and reuse it on every next refetch. because versions are immutable anyway and not gonna change
There was a problem hiding this comment.
I've added a simple caching implementation so each version will have its "executable" property calculated only once
…t showing archived or the other way around
This comment has been minimized.
This comment has been minimized.
…puted once per second
|
✅ Successfully created Preview Deployment. |
2 participants
Summary
Added an option to view all past deployments of a all processes in a space even when the the deployments or the process itself have been removed(/archived).
Details