-
Notifications
You must be signed in to change notification settings - Fork 10
Show Archived Deployments #772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7abb796
Users can now select to be shown archived deployments in the deployme…
jjoderis 6d0fb62
Show all deployable versions in the instance view even when some of t…
jjoderis 3a99074
Allowing users to start the currently selected version in the instanc…
jjoderis 9b08949
Allow users to inspect user tasks of instances started from archived …
jjoderis f1f3f45
Merge branch 'main' of github.com:PROCEED-Labs/proceed into show-arch…
jjoderis a4fd69b
Fixed: if a url contains a query the selection highlighting and autom…
jjoderis efa0c76
Show loading indicator while toggling between showing archived and no…
jjoderis 59c2b44
Fixed: the executions table shows processes that have never been depl…
jjoderis 6fe5767
Caching executable property of process versions so they are not recom…
jjoderis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be honest I am not sure whether I am right or not, or how much effort will it need to implement my suggestion. But fetching all version from db after every 1 second and then parsing it to BpmnObject seems very heavy and expensive (consider we have 7 versions of a large process).
so if I am not wrong then my suggestion is may be we can cash the result of each parse on first load and reuse it on every next refetch. because versions are immutable anyway and not gonna change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a simple caching implementation so each version will have its "executable" property calculated only once