chore: update some message - #73
Conversation
chore: fix some message
There was a problem hiding this comment.
Pull request overview
This PR updates Japanese subtitle text in transaction list components and adds button styling to the Menu component. The changes improve visual consistency by applying established button styling patterns and add clarity to transaction list titles.
Changes:
- Updated subtitle text to include "合計" (total) in Lent and Borrow components
- Added button styling class to Menu component Link elements with consistent border, colors, and spacing
- Added
align-items: centerto mobile layout for better button alignment - Applied consistent
6px doubleborder styling to Group component's group name display
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| products/frontend/src/routes/Root/components/Menu/index.tsx | Added button className to Link components for consistent styling |
| products/frontend/src/routes/Root/components/Menu/index.module.css | Added new button class with styling and improved mobile alignment |
| products/frontend/src/routes/Root/components/Lent/index.tsx | Updated subtitle to include "合計" (total) |
| products/frontend/src/routes/Root/components/Group/index.module.css | Added consistent border styling to group names |
| products/frontend/src/routes/Root/components/Borrow/index.tsx | Updated subtitle to include "合計" (total) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .button { | ||
| display: block; | ||
| text-decoration: none; | ||
| text-align: center; | ||
| font-size: var(--text-lg); | ||
| color: var(--background-color-base); | ||
| background-color: var(--color-base); | ||
| padding: 0 var(--space-sm); | ||
| border: 6px double var(--background-color-base); | ||
| cursor: pointer; | ||
| width: 150px; | ||
| } |
There was a problem hiding this comment.
The .button class has significant duplication with products/frontend/src/share/FormButton/index.module.css. Both share almost identical styles (font-size, color, background-color, padding, border, cursor, display, width). Consider extracting common button styles into a shared CSS variable or class to improve maintainability and ensure consistent styling across the application.
| align-items: center; | ||
| } | ||
| } | ||
|
|
||
| .button { | ||
| display: block; | ||
| text-decoration: none; | ||
| text-align: center; | ||
| font-size: var(--text-lg); | ||
| color: var(--background-color-base); | ||
| background-color: var(--color-base); | ||
| padding: 0 var(--space-sm); | ||
| border: 6px double var(--background-color-base); | ||
| cursor: pointer; | ||
| width: 150px; | ||
| } |
There was a problem hiding this comment.
The PR title "chore: update some message" only mentions message updates, but this file includes significant styling changes (adding new button class with multiple CSS properties and align-items). Consider updating the PR title or description to reflect both the message updates and the styling changes, or split these into separate PRs for better change tracking.
| return ( | ||
| <> | ||
| <SubTitle subTitle="受け取る金額 一覧" /> | ||
| <SubTitle subTitle="受け取る合計金額 一覧" /> |
There was a problem hiding this comment.
The subtitle now says "受け取る合計金額 一覧" (List of total amounts to receive), but the component displays individual amounts from each counterparty, not a summed total. The word "合計" (total) might be ambiguous - it could mean either "all amounts collectively" or "summed total". Consider whether "受け取る金額一覧" (List of amounts to receive) would be clearer, or if showing an actual total sum would better match the new subtitle.
| <SubTitle subTitle="受け取る合計金額 一覧" /> | |
| <SubTitle subTitle="受け取る金額一覧" /> |
| return ( | ||
| <> | ||
| <SubTitle subTitle="返す金額 一覧" /> | ||
| <SubTitle subTitle="返す合計金額 一覧" /> |
There was a problem hiding this comment.
The subtitle now says "返す合計金額 一覧" (List of total amounts to pay back), but the component displays individual amounts to each counterparty, not a summed total. The word "合計" (total) might be ambiguous - it could mean either "all amounts collectively" or "summed total". Consider whether "返す金額一覧" (List of amounts to pay back) would be clearer, or if showing an actual total sum would better match the new subtitle.
| <SubTitle subTitle="返す合計金額 一覧" /> | |
| <SubTitle subTitle="返す金額一覧" /> |
No description provided.