Skip to content

chore: update some message #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Myxogastria0808 merged 2 commits into from
Jan 25, 2026
Merged

chore: update some message #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
726a89a
chore: fix some message
Myxogastria0808 Jan 25, 2026
4661464
Merge pull request #72 from Pay-Crew/sample
Myxogastria0808 Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion products/frontend/src/routes/Root/components/Borrow/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type Props = {
const Borrow: FC<Props> = (props: Props) => {
return (
<>
<SubTitle subTitle="返す金額 一覧" />
<SubTitle subTitle="返す合計金額 一覧" />

Copilot AI Jan 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subtitle now says "返す合計金額 一覧" (List of total amounts to pay back), but the component displays individual amounts to each counterparty, not a summed total. The word "合計" (total) might be ambiguous - it could mean either "all amounts collectively" or "summed total". Consider whether "返す金額一覧" (List of amounts to pay back) would be clearer, or if showing an actual total sum would better match the new subtitle.

Suggested change
<SubTitle subTitle="返す合計金額 一覧" />
<SubTitle subTitle="返す金額一覧" />

Copilot uses AI. Check for mistakes.
{props.paybacks.length === 0 ? (
<p className={styles.message}>返すお金はありません</p>
) : (
Expand Down
1 change: 1 addition & 0 deletions products/frontend/src/routes/Root/components/Group/index.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
max-width: calc(100% - var(--space-sm) * 2);
font-size: var(--text-xl);
color: var(--background-color-base);
border: 6px double var(--background-color-base);
background-color: var(--color-base);
padding: 0 var(--space-sm);
word-wrap: break-word;
Expand Down
2 changes: 1 addition & 1 deletion products/frontend/src/routes/Root/components/Lent/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ type Props = {
const Lent: FC<Props> = (props: Props) => {
return (
<>
<SubTitle subTitle="受け取る金額 一覧" />
<SubTitle subTitle="受け取る合計金額 一覧" />

Copilot AI Jan 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subtitle now says "受け取る合計金額 一覧" (List of total amounts to receive), but the component displays individual amounts from each counterparty, not a summed total. The word "合計" (total) might be ambiguous - it could mean either "all amounts collectively" or "summed total". Consider whether "受け取る金額一覧" (List of amounts to receive) would be clearer, or if showing an actual total sum would better match the new subtitle.

Suggested change
<SubTitle subTitle="受け取る合計金額 一覧" />
<SubTitle subTitle="受け取る金額一覧" />

Copilot uses AI. Check for mistakes.
{props.receivables.length === 0 ? (
<p className={styles.message}>受け取るお金はありません</p>
) : (
Expand Down
14 changes: 14 additions & 0 deletions products/frontend/src/routes/Root/components/Menu/index.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,19 @@
flex-direction: column;
gap: var(--space-base);
text-align: center;
align-items: center;
}
}

.button {
display: block;
text-decoration: none;
text-align: center;
font-size: var(--text-lg);
color: var(--background-color-base);
background-color: var(--color-base);
padding: 0 var(--space-sm);
border: 6px double var(--background-color-base);
cursor: pointer;
width: 150px;
}
Comment on lines +24 to +35

Copilot AI Jan 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .button class has significant duplication with products/frontend/src/share/FormButton/index.module.css. Both share almost identical styles (font-size, color, background-color, padding, border, cursor, display, width). Consider extracting common button styles into a shared CSS variable or class to improve maintainability and ensure consistent styling across the application.

Copilot uses AI. Check for mistakes.
Comment on lines +20 to +35

Copilot AI Jan 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title "chore: update some message" only mentions message updates, but this file includes significant styling changes (adding new button class with multiple CSS properties and align-items). Consider updating the PR title or description to reflect both the message updates and the styling changes, or split these into separate PRs for better change tracking.

Copilot uses AI. Check for mistakes.
8 changes: 6 additions & 2 deletions products/frontend/src/routes/Root/components/Menu/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,12 @@ import styles from './index.module.css';
const Menu: FC = () => {
return (
<div className={styles.welcomeBox}>
<Link to="/profile">アカウント設定</Link>
<Link to="/gen-group">グループ作成</Link>
<Link className={styles.button} to="/profile">
アカウント設定
</Link>
<Link className={styles.button} to="/gen-group">
グループ作成
</Link>
</div>
);
};
Expand Down
Loading