Skip to content

fix(build): restore the web build dependency of @rivus/estela - #145

Merged
PerfectPan merged 1 commit into
mainfrom
fix/web-build-dependency
Nov 17, 2026
Merged

PerfectPan merged 1 commit into
mainfrom
fix/web-build-dependency

Conversation

@PerfectPan

Copy link
Copy Markdown
Owner

Summary

The 0.4.0 release failed before publishing. Its Publish run (44054543793, release commit 66b82ac) failed in "check and pack packages". The check command pnpm -C apps/e2e run test:smoke builds pnpm --filter '@rivus/estela...' run build, and vp pack in apps/cli copies ../web/dist (apps/cli/vite.config.ts). That directory did not exist: ENOENT: no such file or directory, lstat 'apps/web/dist'. Nothing was published or tagged; npm still has 0.3.1.

Cause: #134 removed the @rivus/estela-web devDependency of @rivus/estela, because Knip saw no import of it. That dependency is what puts apps/web into the @rivus/estela... filter, and ahead of apps/cli in pnpm -r build. CI did not notice, because ci.yml builds Web on its own before the smoke step. The 0.3.1 release came before #134.

  • apps/cli/package.json: restore "@rivus/estela-web": "workspace:*" in devDependencies.
  • knip.ts: ignoreDependencies: ['@rivus/estela-web'] for apps/cli, with the reason (build order, not an import).

No changeset. This is an exception to Release Intent, which counts apps/cli/package.json as shipped. The release workflow's failure recovery (npm-release.md, "check and pack failed") says a fix without records publishes the same version from its merge push. A fix with a record goes into the next version PR instead, and an empty record leaves the workflow in none mode; either way 0.4.0 would not publish. Users see no change: npm does not install a package's devDependencies, and pnpm pack writes this one as "@rivus/estela-web": "0.0.0", as 0.3.1 on npm already has it. #134 removed the same devDependency without a changeset.

Validation

  • pnpm --filter '@rivus/estela...' ls --depth -1: the scope now includes @rivus/estela-web (7 packages; the failed run built 6).
  • Publish check simulation, on this branch rebased onto the release commit 66b82ac (version 0.4.0, no pending changesets): rm -rf apps/web/dist apps/cli/dist && pnpm -C apps/e2e run test:smoke packed rivus-estela-0.4.0.tgz with dist/web and passed 19 of 19. The release audit pnpm --filter '@rivus/estela...' audit --audit-level=high, whose scope now includes the web app again, found no known vulnerabilities.
  • pnpm --filter @rivus/estela-schema run knip: passed.
  • node scripts/check-layers.mjs, node scripts/format.mjs --check, node scripts/lint-scripts.mjs: passed.
  • gh repo-checks pr-title, gh repo-checks pr-body: passed.

Risks

vp pack copies apps/web/dist into the package, so the web app has to be
in the @rivus/estela... build filter that the smoke suite and the Publish
check run. Knip removed the devDependency as unused, which left 0.4.0's
Publish check without a web build. Knip now keeps it, with the reason.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@PerfectPan
PerfectPan merged commit d90ca2b into main Nov 17, 2026
7 checks passed
@PerfectPan
PerfectPan deleted the fix/web-build-dependency branch November 17, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant