Repository navigation
fix(build): restore the web build dependency of @rivus/estela - #145
Merged
Merged
Conversation
vp pack copies apps/web/dist into the package, so the web app has to be in the @rivus/estela... build filter that the smoke suite and the Publish check run. Knip removed the devDependency as unused, which left 0.4.0's Publish check without a web build. Knip now keeps it, with the reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 0.4.0 release failed before publishing. Its Publish run (44054543793, release commit 66b82ac) failed in "check and pack packages". The check command
pnpm -C apps/e2e run test:smokebuildspnpm --filter '@rivus/estela...' run build, andvp packinapps/clicopies../web/dist(apps/cli/vite.config.ts). That directory did not exist:ENOENT: no such file or directory, lstat 'apps/web/dist'. Nothing was published or tagged; npm still has 0.3.1.Cause: #134 removed the
@rivus/estela-webdevDependency of@rivus/estela, because Knip saw no import of it. That dependency is what putsapps/webinto the@rivus/estela...filter, and ahead ofapps/cliinpnpm -r build. CI did not notice, becauseci.ymlbuilds Web on its own before the smoke step. The 0.3.1 release came before #134.apps/cli/package.json: restore"@rivus/estela-web": "workspace:*"indevDependencies.knip.ts:ignoreDependencies: ['@rivus/estela-web']forapps/cli, with the reason (build order, not an import).No changeset. This is an exception to Release Intent, which counts
apps/cli/package.jsonas shipped. The release workflow's failure recovery (npm-release.md, "check and pack failed") says a fix without records publishes the same version from its merge push. A fix with a record goes into the next version PR instead, and an empty record leaves the workflow innonemode; either way 0.4.0 would not publish. Users see no change: npm does not install a package's devDependencies, andpnpm packwrites this one as"@rivus/estela-web": "0.0.0", as 0.3.1 on npm already has it. #134 removed the same devDependency without a changeset.Validation
pnpm --filter '@rivus/estela...' ls --depth -1: the scope now includes@rivus/estela-web(7 packages; the failed run built 6).rm -rf apps/web/dist apps/cli/dist && pnpm -C apps/e2e run test:smokepackedrivus-estela-0.4.0.tgzwithdist/weband passed 19 of 19. The release auditpnpm --filter '@rivus/estela...' audit --audit-level=high, whose scope now includes the web app again, found no known vulnerabilities.pnpm --filter @rivus/estela-schema run knip: passed.node scripts/check-layers.mjs,node scripts/format.mjs --check,node scripts/lint-scripts.mjs: passed.gh repo-checks pr-title,gh repo-checks pr-body: passed.Risks