Skip to content

ci: run the duplicates gate in the test job - #151

Merged
PerfectPan merged 1 commit into
mainfrom
ci/duplicates-gate
Nov 18, 2026
Merged

PerfectPan merged 1 commit into
mainfrom
ci/duplicates-gate

Conversation

@PerfectPan

Copy link
Copy Markdown
Owner

Summary

  • Run the existing duplicates gate in the CI test job: pnpm --filter @rivus/estela-schema run duplicates. refactor: extract the staged duplicate helpers and drop the knip export staging #138 added the script as the gate (jscpd with @perfectpan/lint-config's zero-threshold jscpd.json), but no workflow ran it, so a PR that added a clone still passed. main is at 0 clones, so the gate passes today and fails on the first new clone.
  • List the command in the AGENTS.md Commands block, the CONTRIBUTING.md setup list and Pull Request Gates section, docs/development/setup.md (with its Chinese copy re-recorded), and the Validation checklist of the PR and MR templates (kept in sync).
  • No shipped files change, so there is no changeset.

Validation

  • pnpm --filter @rivus/estela-schema run duplicates on this branch: Found 0 clones., exit 0 (206 files).
  • With a copy of packages/kernel/src/fold.ts added as packages/kernel/src/dup-probe.ts: Found 1 clones., ERROR: jscpd found too many duplicates (0.5%) over threshold (0.0%), exit 1. After deleting the copy: Found 0 clones., exit 0. The copy was not committed.
  • gh repo-checks repository: ok.
  • node scripts/check-doc-translations.mjs: ok (15 pairs).
  • node scripts/check-conventions.mjs: ok (452 files).
  • The workflow YAML parses; CI on this PR is the check that the step runs.
  • Skipped locally: lint, test, typecheck, build, budgets and e2e, because no code changed; CI runs them.

The duplicates script (jscpd with lint-config's zero-threshold profile)
was added as a gate, but no workflow ran it, so new clones passed CI.
Run it in the test job and list it with the other local checks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@PerfectPan
PerfectPan merged commit 5090767 into main Nov 18, 2026
12 of 13 checks passed
@PerfectPan
PerfectPan deleted the ci/duplicates-gate branch November 18, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant