Repository navigation
ci: run the duplicates gate in the test job - #151
Merged
Merged
Conversation
The duplicates script (jscpd with lint-config's zero-threshold profile) was added as a gate, but no workflow ran it, so new clones passed CI. Run it in the test job and list it with the other local checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
duplicatesgate in the CItestjob:pnpm --filter @rivus/estela-schema run duplicates. refactor: extract the staged duplicate helpers and drop the knip export staging #138 added the script as the gate (jscpd with@perfectpan/lint-config's zero-thresholdjscpd.json), but no workflow ran it, so a PR that added a clone still passed.mainis at 0 clones, so the gate passes today and fails on the first new clone.docs/development/setup.md(with its Chinese copy re-recorded), and the Validation checklist of the PR and MR templates (kept in sync).Validation
pnpm --filter @rivus/estela-schema run duplicateson this branch:Found 0 clones., exit 0 (206 files).packages/kernel/src/fold.tsadded aspackages/kernel/src/dup-probe.ts:Found 1 clones.,ERROR: jscpd found too many duplicates (0.5%) over threshold (0.0%), exit 1. After deleting the copy:Found 0 clones., exit 0. The copy was not committed.gh repo-checks repository: ok.node scripts/check-doc-translations.mjs: ok (15 pairs).node scripts/check-conventions.mjs: ok (452 files).