Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
- [ ] Changeset for shipped changes: a file under `.changeset/` (documentation-only and workflow-only PRs need none)
- [ ] Lint, test, typecheck, build: `pnpm lint`, `pnpm test`, `pnpm typecheck`, `pnpm build`
- [ ] Browser bundle: `node scripts/check-browser-bundle.mjs`
- [ ] Duplicate code: `pnpm --filter @rivus/estela-schema run duplicates` (any reported clone fails)
- [ ] Performance and size budgets, after `pnpm build`: `node scripts/check-budgets.mjs` (a change that outgrows a size budget raises it in `scripts/budgets/budgets.mjs` with the new number and reason)

## Risks
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ jobs:
# Both run the vite-plus from apps/cli's devDependencies, so they run after the install.
- run: node scripts/format.mjs --check
- run: node scripts/lint-scripts.mjs
# Fails on any clone jscpd reports (lint-config's zero-threshold profile). The scan roots and ignores live in the
# script in packages/schema/package.json.
- run: pnpm --filter @rivus/estela-schema run duplicates
- run: node scripts/check-browser-bundle.mjs
- name: Build Web once before CLI smoke tests
run: pnpm --filter @rivus/estela-web run build
Expand Down
1 change: 1 addition & 0 deletions .gitlab/merge_request_templates/default.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
- [ ] Changeset for shipped changes: a file under `.changeset/` (documentation-only and workflow-only MRs need none)
- [ ] Lint, test, typecheck, build: `pnpm lint`, `pnpm test`, `pnpm typecheck`, `pnpm build`
- [ ] Browser bundle: `node scripts/check-browser-bundle.mjs`
- [ ] Duplicate code: `pnpm --filter @rivus/estela-schema run duplicates` (any reported clone fails)
- [ ] Performance and size budgets, after `pnpm build`: `node scripts/check-budgets.mjs` (a change that outgrows a size budget raises it in `scripts/budgets/budgets.mjs` with the new number and reason)

## Risks
Expand Down
1 change: 1 addition & 0 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ node scripts/lint-scripts.mjs
pnpm lint
pnpm test
pnpm typecheck
pnpm --filter @rivus/estela-schema run duplicates
pnpm build
node scripts/check-layers.mjs
node scripts/check-browser-bundle.mjs
Expand Down
7 changes: 7 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ node scripts/lint-scripts.mjs
pnpm lint
pnpm test
pnpm typecheck
pnpm --filter @rivus/estela-schema run duplicates
pnpm build
cd apps/cli && pnpm run dev
```
Expand Down Expand Up @@ -281,6 +282,12 @@ A `vite-plus` upgrade also moves the catalog's `vite` entry (the vite-plus-core
`apps/web`'s `rolldown` devDependency to that core's `bundledVersions.rolldown`; the CLI build fails while the
`rolldown` pin differs.

The `test` job also runs `pnpm --filter @rivus/estela-schema run duplicates`: jscpd with lint-config's gate profile,
where any reported clone fails the run (the threshold is 0). The scan roots and ignores live in the script in
`packages/schema/package.json`: it skips `*.test.ts` unit tests but scans the e2e and smoke specs.
`pnpm --filter @rivus/estela-schema run duplicates:audit` writes a broader report, which also covers test files and
near-identical code, to the git-ignored `tmp/duplicates-audit/` and fails nothing.

`pnpm/setup@v3` caches the pnpm content-addressed store, keyed by the lockfile's content hash. Every run still
executes `pnpm install --frozen-lockfile` and the checks. Installed workspace links, build outputs, credentials and
CI results are not cached. Keep cache storage inside the included repository allowance.
Expand Down
1 change: 1 addition & 0 deletions docs/development/setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ node scripts/format.mjs --check
pnpm lint
pnpm test
pnpm typecheck
pnpm --filter @rivus/estela-schema run duplicates
pnpm build
node scripts/check-budgets.mjs
```
Expand Down
3 changes: 2 additions & 1 deletion docs/development/setup.zh-CN.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
> 中文阅读版。以英文原文 docs/development/setup.md 为准。

<!-- source-blob: 543b585d6eea605bebded51fc0624e6e2e9cf8ba -->
<!-- source-blob: dfb9b7601ac9f948bdf14e34daee501fefdf8127 -->

# 开发

Expand Down Expand Up @@ -28,6 +28,7 @@ node scripts/format.mjs --check
pnpm lint
pnpm test
pnpm typecheck
pnpm --filter @rivus/estela-schema run duplicates
pnpm build
node scripts/check-budgets.mjs
```
Expand Down
Loading