Repository navigation
ci(template): skip full Rush checks on draft pull requests - #26
Merged
Merged
Conversation
PerfectPan
marked this pull request as ready for review
November 3, 2026 08:59
PerfectPan
marked this pull request as draft
November 3, 2026 09:01
PerfectPan
marked this pull request as ready for review
November 3, 2026 09:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopt the Ready-PR full-CI policy prepared first in the base template PR. The Rush template already listens to PR creation, new commits, reopening and Ready transitions; add a job-level condition so Draft PRs skip the full
checkjob while main pushes keep running it.Keep the Rush installation, cache, all check steps, lightweight Review workflow, publishing workflows and release PR Draft behavior unchanged. Update the contributing guide, README and release runbook to explain actual Ready validation, preserve early Review feedback, and remove the obsolete suggestions that reopening or pushing to a still-Draft release PR runs full CI. No package, dependency, lockfile or release changes are included, so no Rush change file is needed.
Validation
gh repo-checks repositoryandgit diff --checkpassed.actionlint1.7.12 passed for CI and Review.draft: always-truerelease setting, and unchanged CI steps. This is static configuration validation, not proof of hosted event delivery.check, while Review ran successfully. It was then temporarily marked Ready: CI run 41607373085 and Review run 41607373095 both passed on exact head75829e37d0227f3c1fca043f8e865489778eebdb. The fullcheckjob executed Rush installation,npm run check(format, build, lint, typecheck and test) and the change-file/release-intent checks in 42 seconds. Checkout logs show mergef5a6099778c2bcdc1a977f219291b134afdca086, combining this head with mainc05da39001e10395a390f9b794fe933ce5809409. The PR has been restored to Draft. The skipped Draft run is not counted as a passing suite; full checks were verified remotely rather than rerun locally for this workflow/documentation-only change.Risks
GitHub reports a skipped job as successful, including required checks. A maintainer must verify that the current Ready comparison has an actually executed, successful
checkbefore merging. Draft Review remains enabled for repository/title/body feedback. Automation usingGITHUB_TOKENcan require GitHub workflow approval; this change does not broaden token permissions.Read-only inspection found no classic protection on
mainand no rulesets. No settings are changed, and this PR does not itself enforce merge protection. Keep release PRs Draft until reviewed, and use the normal Ready transition after each version update. No PR will be merged by this task.