Skip to content

ci(template): skip full Rush checks on draft pull requests - #26

Merged
PerfectPan merged 1 commit into
mainfrom
ci/ready-pr-checks
Nov 3, 2026
Merged

PerfectPan merged 1 commit into
mainfrom
ci/ready-pr-checks

Conversation

@PerfectPan

@PerfectPan PerfectPan commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner

Summary

Adopt the Ready-PR full-CI policy prepared first in the base template PR. The Rush template already listens to PR creation, new commits, reopening and Ready transitions; add a job-level condition so Draft PRs skip the full check job while main pushes keep running it.

Keep the Rush installation, cache, all check steps, lightweight Review workflow, publishing workflows and release PR Draft behavior unchanged. Update the contributing guide, README and release runbook to explain actual Ready validation, preserve early Review feedback, and remove the obsolete suggestions that reopening or pushing to a still-Draft release PR runs full CI. No package, dependency, lockfile or release changes are included, so no Rush change file is needed.

Validation

  • gh repo-checks repository and git diff --check passed.
  • actionlint 1.7.12 passed for CI and Review.
  • A local 35-case matrix parsed the actual YAML and evaluated Ready/Draft PR events, metadata exclusions and preserved main pushes. It also verified byte-identical Review, Version Packages and Publish workflows, the existing draft: always-true release setting, and unchanged CI steps. This is static configuration validation, not proof of hosted event delivery.
  • PR title and description gates passed locally. No new persistent test framework was added for the single workflow condition.
  • The PR was created as Draft: CI run 41607163957 skipped check, while Review ran successfully. It was then temporarily marked Ready: CI run 41607373085 and Review run 41607373095 both passed on exact head 75829e37d0227f3c1fca043f8e865489778eebdb. The full check job executed Rush installation, npm run check (format, build, lint, typecheck and test) and the change-file/release-intent checks in 42 seconds. Checkout logs show merge f5a6099778c2bcdc1a977f219291b134afdca086, combining this head with main c05da39001e10395a390f9b794fe933ce5809409. The PR has been restored to Draft. The skipped Draft run is not counted as a passing suite; full checks were verified remotely rather than rerun locally for this workflow/documentation-only change.

Risks

GitHub reports a skipped job as successful, including required checks. A maintainer must verify that the current Ready comparison has an actually executed, successful check before merging. Draft Review remains enabled for repository/title/body feedback. Automation using GITHUB_TOKEN can require GitHub workflow approval; this change does not broaden token permissions.

Read-only inspection found no classic protection on main and no rulesets. No settings are changed, and this PR does not itself enforce merge protection. Keep release PRs Draft until reviewed, and use the normal Ready transition after each version update. No PR will be merged by this task.

@PerfectPan
PerfectPan marked this pull request as ready for review November 3, 2026 08:59
@PerfectPan
PerfectPan marked this pull request as draft November 3, 2026 09:01
@PerfectPan
PerfectPan marked this pull request as ready for review November 3, 2026 09:17
@PerfectPan
PerfectPan merged commit 091d223 into main Nov 3, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant