Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tunnel manager keeps the last few KB of each ssh process's stderr. Once that buffer passed 8192 bytes it cut it down with
drain(..len - 4096), a byte offset, so when the cut landed inside a multibyte character (any non-ASCII ssh message, a localized error or a hostname)String::drainpanicked in the stderr reader thread.I moved the append and trim into
push_stderr_lineand made it step back to a character boundary before draining, the same waypush_cappedinsession/mod.rsalready does. The new test pushes lines of two-byte characters past the cap repeatedly; it panicked before the change and now keeps the buffer under the cap. I also added a CHANGELOG entry.