Repository navigation
Conversation
Owner
|
Thanks for adding the Dominican Republic and Peru aliases and channel databases. I made a few fixes and could not push them to your branch, so your commit and mine are together in #61. Your commit is included unchanged with your name on it. I am closing this one in favour of #61. What I changed:
One thing to know when testing: the country aliases apply only when Channel Database is set to exactly |
PiratesIRC
added a commit
that referenced
this pull request
Sep 25, 2026
Add country-specific aliases for DO and PE (from #58, with review fixes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Adds country-specific aliases for the Dominican Republic (DO) and Peru (PE), enhancing localization support.
Why
This change improves user experience by providing more relevant identifiers for users in these countries.
Fixes #
How it was verified
python -m pytest -qpassesAnything a reviewer should know
No significant trade-offs or uncertainties were encountered during this implementation.
Please confirm:
python scripts/bump_version.py, or this change does not need a version bump.