Add country-specific aliases for DO and PE (from #58, with review fixes) - #61
Merged
Merged
Conversation
…nd aliases Review fixes on top of the DO and PE aliases. - Remove DR_channels.json. It was DO_channels.json with country_code DR. The plugin tags every channel with its database code, and a DR: stream prefix is already read as DO, so with Channel Database set to DR every Dominican stream looked foreign under Restrict Matching To Same Country, and with All the two files disagreed for all 309 names so the database country was dropped for each of them. - DO_channels.json: remove the second entry of Teleunion, Entelevision and ESPN 2, each repeated under the HD category. - aliases.py: keep the existing US entries as they were on main (they had been reformatted with no change in value) and add only the DO and PE COUNTRY_ALIASES sections. Loaded values checked equal to the original PR. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This carries @taos15's commit from #58 unchanged, with authorship kept, plus one commit of review fixes. The fixes could not be pushed to the fork's branch from here, so they are in this pull request.
From #58
DO_channels.json(Dominican Republic) andPE_channels.json(Peru).COUNTRY_ALIASESentries for DO (94 channels) and PE (62 channels).Review fixes (39d76df)
DR_channels.json. It wasDO_channels.jsonwithcountry_codeset toDR. The plugin tags every channel with its database code, and aDR:stream prefix is already read asDO. Measured on the Add country-specific aliases for DO and PE #58 branch by calling_channel_country_code: DO alone givesDO, DR alone givesDR, and both loaded together (Channel Database set to All) give no country for all 309 names. With DR selected and Restrict Matching To Same Country on, every Dominican stream would have been removed as foreign.DO_channels.json: removed the second entry ofTeleunión,EntelevisiónandESPN 2, each repeated under theHDcategory. There are now 306 entries, all unique.aliases.py: the existing US entries are left as they are onmain. Add country-specific aliases for DO and PE #58 had reformatted them with no change in value. Only the DO and PE sections are added. Loaded values checked:CHANNEL_ALIASESequalsmain, andCOUNTRY_ALIASESequals Add country-specific aliases for DO and PE #58.Known limit, not changed here
The country aliases apply only when Channel Database is set to exactly
DOorPE. With All selected,_build_alias_maplooks upCOUNTRY_ALIASES["ALL"]and finds nothing. That is existing behaviour for every country.Testing
The full suite passes (1559),
scripts/validate_databases.pyreports all 15 databases valid, and the publish audit is clean.🤖 Generated with Claude Code