Fix modal overlay dismissal in QMS tests#11
Open
ArtyomSavchenko wants to merge 2 commits into
Open
Conversation
The TESTS-206 test intermittently timed out clicking buttonComments because a modal-overlay from the add-message popup remained and intercepted pointer events. Escape only closes the topmost popup, so a single Escape + click left a second overlay behind when more than one popup was open. Dismiss popups in a loop until no modal-overlay remains and assert it is gone before returning, so subsequent clicks are not blocked. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012JGaU2EosGSuqyQCss1rh1
Signed-off-by: Artem Savchenko <armisav@gmail.com>
ArtyomSavchenko
changed the title
aonnikov
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhanced the
closeNewMessagePopupmethod to properly handle multiple stacked modal overlays that can remain open after adding a message, which was causing subsequent clicks to time out.Key Changes
Implementation Details
The previous implementation only pressed Escape once, which was insufficient when multiple modal popups were stacked. Each overlay intercepts pointer events, so lingering overlays would cause subsequent click actions to time out. The new implementation:
https://claude.ai/code/session_012JGaU2EosGSuqyQCss1rh1