Skip to content

Fix modal overlay dismissal in QMS tests #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArtyomSavchenko wants to merge 2 commits into
base: develop
Choose a base branch
from
+14 −1
Open

Fix modal overlay dismissal in QMS tests #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb95f95
fix(qms-tests): make closeNewMessagePopup dismiss all lingering overlays
claude Jul 13, 2026
808d80c
Fix formatting
ArtyomSavchenko Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion qms-tests/sanity/tests/model/documents/document-content-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,8 +825,21 @@ export class DocumentContentPage extends DocumentCommonPage {
}

async closeNewMessagePopup (): Promise<void> {
await this.textPageHeader.press('Escape', { delay: 300 })
const overlay = this.page.locator('div.modal-overlay')
// Adding a message can leave one or more popups open, each rendering a modal
// overlay that intercepts pointer events for the following actions. Escape
// only closes the topmost popup, so keep dismissing until no overlay remains,
// otherwise a lingering overlay makes subsequent clicks time out.
for (let attempt = 0; attempt < 5; attempt++) {
if ((await overlay.count()) === 0) break
await this.textPageHeader.press('Escape', { delay: 300 })
await overlay
.first()
.waitFor({ state: 'detached', timeout: 1000 })
.catch(() => {})
}
await this.textPageHeader.click({ force: true, delay: 300, position: { x: 1, y: 1 } })
await expect(overlay).toHaveCount(0, { timeout: 5000 })
}

async completeReview (): Promise<void> {
Expand Down
Loading