Add duplicate-key validation for model config JSONs#581
Open
akhilmmenon wants to merge 7 commits intomainfrom
Open
Add duplicate-key validation for model config JSONs#581akhilmmenon wants to merge 7 commits intomainfrom
akhilmmenon wants to merge 7 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds CI validation to prevent silent overrides in general/*.json and pricing/*.json by detecting duplicate JSON object keys and duplicate params[].key entries, complementing existing jq syntax checks.
Changes:
- Added
scripts/check_duplicate_keys.pyto detect duplicate JSON object keys and duplicateparams[].keyvalues. - Updated
validate-json.ymlto run onpushtomain(path-filtered) in addition topull_request. - Added a workflow step to execute the duplicate-key validation script after
jqvalidation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| scripts/check_duplicate_keys.py | New Python validator to detect duplicate JSON object keys and duplicate params[].key entries. |
| .github/workflows/validate-json.yml | Adds push trigger and runs the new duplicate-key validator in CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/check_duplicate_keys.pyto catch:"gpt-4")params[].keyvalues within the sameparamsarray (e.g. two"max_tokens"entries).github/workflows/validate-json.ymlto run on bothpushandpull_requesttomainforpricing/**andgeneral/**python3 scripts/check_duplicate_keys.pyafter existingjqsyntax checksWhy
jq emptyonly validates JSON syntax and does not fail when duplicate object keys exist.This change prevents silent config overrides and conflicting param definitions from being merged.
Test plan
models/:python3 scripts/check_duplicate_keys.py::errorannotations when duplicates are foundNotes
params[].keyentries (e.g.response_formatin certaingpt-5*sections), so CI may fail until those are cleaned up.