Skip to content

Add duplicate-key validation for model config JSONs #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akhilmmenon wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add duplicate-key validation for model config JSONs #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b637fe1
Duplicate check for objects and params key entries
Apr 2, 2026
ae22c3d
Removed branches and paths constraint
Apr 2, 2026
a4eec67
Modified params for gpt-5 models
Apr 2, 2026
b2ff470
Removed duplicate params and modified checker to show filename and path
Apr 2, 2026
3bd090a
Testing duplicate key error
Apr 2, 2026
d5d2eb5
Path fix for github action
Apr 2, 2026
7099cc7
Removed test case
Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/validate-json.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
name: Validate JSON
on:
push:
pull_request:
branches:
- main
Expand Down Expand Up @@ -43,3 +44,7 @@ jobs:
if [ $ERRORS -gt 0 ]; then
exit 1
fi

- name: Check duplicate keys in configs
run: |
python3 scripts/check_duplicate_keys.py
103 changes: 0 additions & 103 deletions general/azure-ai.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1537,41 +1537,6 @@
"skipValues": [null],
"type": "string"
},
{
"key": "response_format",
"defaultValue": null,
"options": [
{
"value": null,
"name": "Text"
},
{
"value": "json_object",
"name": "JSON Object",
"schema": {
"type": "object",
"properties": {
"type": { "type": "string", "value": "json_object" }
}
}
},
{
"value": "json_schema",
"name": "JSON Schema",
"schema": {
"type": "object",
"properties": {
"type": { "type": "string", "value": "json_schema" },
"json_schema": { "type": "object" }
}
},
"params": { "key": "json_schema", "defaultValue": null, "type": "json", "skipValues": [null] }
}
],
"skipValues": [null],
"type": "string"
},

{ "key": "verbosity", "enum": ["low", "medium", "high", null], "defaultValue": null, "skipValues": [null] },
{
"key": "reasoning",
Expand Down Expand Up @@ -2024,40 +1989,6 @@
],
"params": [
{ "key": "max_completion_tokens", "defaultValue": 20000, "minValue": 1, "maxValue": 272000 },
{
"key": "response_format",
"defaultValue": null,
"options": [
{
"value": null,
"name": "Text"
},
{
"value": "json_object",
"name": "JSON Object",
"schema": {
"type": "object",
"properties": {
"type": { "type": "string", "value": "json_object" }
}
}
},
{
"value": "json_schema",
"name": "JSON Schema",
"schema": {
"type": "object",
"properties": {
"type": { "type": "string", "value": "json_schema" },
"json_schema": { "type": "object" }
}
},
"params": { "key": "json_schema", "defaultValue": null, "type": "json", "skipValues": [null] }
}
],
"skipValues": [null],
"type": "string"
},
{
"key": "response_format",
"defaultValue": null,
Expand Down Expand Up @@ -2110,40 +2041,6 @@
],
"params": [
{ "key": "max_completion_tokens", "defaultValue": 20000, "minValue": 1, "maxValue": 272000 },
{
"key": "response_format",
"defaultValue": null,
"options": [
{
"value": null,
"name": "Text"
},
{
"value": "json_object",
"name": "JSON Object",
"schema": {
"type": "object",
"properties": {
"type": { "type": "string", "value": "json_object" }
}
}
},
{
"value": "json_schema",
"name": "JSON Schema",
"schema": {
"type": "object",
"properties": {
"type": { "type": "string", "value": "json_schema" },
"json_schema": { "type": "object" }
}
},
"params": { "key": "json_schema", "defaultValue": null, "type": "json", "skipValues": [null] }
}
],
"skipValues": [null],
"type": "string"
},
{
"key": "response_format",
"defaultValue": null,
Expand Down
118 changes: 0 additions & 118 deletions general/azure-openai.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2115,46 +2115,6 @@
"skipValues": [null],
"type": "string"
},
{
"key": "response_format",
"defaultValue": null,
"options": [
{
"value": null,
"name": "Text"
},
{
"value": "json_object",
"name": "JSON Object",
"schema": {
"type": "object",
"properties": {
"type": { "type": "string", "value": "json_object" }
}
}
},
{
"value": "json_schema",
"name": "JSON Schema",
"schema": {
"type": "object",
"properties": {
"type": { "type": "string", "value": "json_schema" },
"json_schema": { "type": "object" }
}
},
"params": {
"key": "json_schema",
"defaultValue": null,
"type": "json",
"skipValues": [null]
}
}
],
"skipValues": [null],
"type": "string"
},

{
"key": "verbosity",
"enum": ["low", "medium", "high", null],
Expand Down Expand Up @@ -2651,45 +2611,6 @@
"minValue": 1,
"maxValue": 272000
},
{
"key": "response_format",
"defaultValue": null,
"options": [
{
"value": null,
"name": "Text"
},
{
"value": "json_object",
"name": "JSON Object",
"schema": {
"type": "object",
"properties": {
"type": { "type": "string", "value": "json_object" }
}
}
},
{
"value": "json_schema",
"name": "JSON Schema",
"schema": {
"type": "object",
"properties": {
"type": { "type": "string", "value": "json_schema" },
"json_schema": { "type": "object" }
}
},
"params": {
"key": "json_schema",
"defaultValue": null,
"type": "json",
"skipValues": [null]
}
}
],
"skipValues": [null],
"type": "string"
},
{
"key": "response_format",
"defaultValue": null,
Expand Down Expand Up @@ -2752,45 +2673,6 @@
"minValue": 1,
"maxValue": 272000
},
{
"key": "response_format",
"defaultValue": null,
"options": [
{
"value": null,
"name": "Text"
},
{
"value": "json_object",
"name": "JSON Object",
"schema": {
"type": "object",
"properties": {
"type": { "type": "string", "value": "json_object" }
}
}
},
{
"value": "json_schema",
"name": "JSON Schema",
"schema": {
"type": "object",
"properties": {
"type": { "type": "string", "value": "json_schema" },
"json_schema": { "type": "object" }
}
},
"params": {
"key": "json_schema",
"defaultValue": null,
"type": "json",
"skipValues": [null]
}
}
],
"skipValues": [null],
"type": "string"
},
{
"key": "response_format",
"defaultValue": null,
Expand Down
Loading
Loading