forked from NVIDIA/Isaac-GR00T
-
Notifications
You must be signed in to change notification settings - Fork 0
Preserve native DROID checkpoint behavior for Positronic #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vertix
wants to merge
7
commits into
main-positronic
Choose a base branch
from
groot-1.7
base: main-positronic
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e08b870
Preserve DROID checkpoint defaults for N1.7 fine-tuning and serving
vertix b61c478
Use checkpoint image settings for fine-tuning
vertix 9d17a03
Honor checkpoint overrides and inference input contracts
vertix bc91bc1
Document camera overrides through the fine-tuning wrapper
vertix e63c6f7
Use the selected inference instruction in the sim wrapper
vertix ee9dd54
Keep the N1.7 upgrade focused on checkpoint compatibility
vertix be79d62
Preserve amd64 Docker builds from Mac
vertix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| name: Build and Push Gr00t Images | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main-positronic | ||
|
|
||
| jobs: | ||
| build-and-push: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Free disk space | ||
| run: | | ||
| sudo rm -rf /usr/share/dotnet | ||
| sudo rm -rf /usr/local/lib/android | ||
| sudo rm -rf /opt/ghc | ||
| sudo rm -rf "${AGENT_TOOLSDIRECTORY:-/opt/hostedtoolcache}/CodeQL" | ||
| sudo rm -rf "${AGENT_TOOLSDIRECTORY:-/opt/hostedtoolcache}/node" | ||
| sudo rm -rf "${AGENT_TOOLSDIRECTORY:-/opt/hostedtoolcache}/go" | ||
| sudo rm -rf /usr/lib/jvm | ||
| sudo docker system prune -af || true | ||
| df -h | ||
|
|
||
| - name: Log in to Docker Hub | ||
| uses: docker/login-action@v3 | ||
| with: | ||
| username: ${{ secrets.DOCKER_USERNAME }} | ||
| password: ${{ secrets.DOCKER_PASSWORD }} | ||
|
|
||
| - name: Build and Push | ||
| working-directory: docker | ||
| run: | | ||
| make push | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| .PHONY: all build tag push clean prune help | ||
|
|
||
| # Image configuration | ||
| IMAGE_NAME_GROOT := positro/gr00t-base | ||
|
|
||
| # Extract version from pyproject.toml (first literal version entry) | ||
| VERSION := $(shell sed -n 's/^version = "\([^"]*\)"/\1/p' ../pyproject.toml | head -n 1) | ||
|
|
||
| GIT_SHA := $(shell git rev-parse --short HEAD 2>/dev/null || echo "unknown") | ||
|
|
||
| REGISTRY_URL ?= docker.io | ||
|
|
||
| TAG_GROOT_LATEST := $(IMAGE_NAME_GROOT):latest | ||
| TAG_GROOT_VERSION := $(IMAGE_NAME_GROOT):v$(VERSION) | ||
| TAG_GROOT_SHA := $(IMAGE_NAME_GROOT):$(GIT_SHA) | ||
| LOCAL_TAG_GROOT := $(IMAGE_NAME_GROOT):local | ||
|
|
||
| help: | ||
| @echo "gr00t Groot Docker Build System" | ||
| @echo "" | ||
| @echo "Configuration:" | ||
| @echo " Groot Image: $(IMAGE_NAME_GROOT)" | ||
| @echo " Version: $(VERSION)" | ||
| @echo " Git SHA: $(GIT_SHA)" | ||
| @echo " Registry URL: $(REGISTRY_URL)" | ||
| @echo "" | ||
| @echo "Targets:" | ||
| @echo " make build Build the groot image" | ||
| @echo " make tag Tag the groot image" | ||
| @echo " make push Push groot tags to Docker Hub" | ||
| @echo " make clean Remove local groot images" | ||
| @echo " make prune Remove dangling/unused Docker images" | ||
| @echo " make help Show this help message" | ||
| @echo "" | ||
|
|
||
| build: | ||
| @echo "Building $(IMAGE_NAME_GROOT) image..." | ||
| @if [ -z "$(VERSION)" ]; then \ | ||
| echo "Error: Could not extract version from pyproject.toml"; \ | ||
| exit 1; \ | ||
| fi | ||
| docker build --platform linux/amd64 \ | ||
| -f Dockerfile \ | ||
| -t $(LOCAL_TAG_GROOT) .. | ||
|
|
||
| tag: build | ||
| @echo "Tagging groot image with multiple tags..." | ||
| docker tag $(LOCAL_TAG_GROOT) $(TAG_GROOT_LATEST) | ||
| docker tag $(LOCAL_TAG_GROOT) $(TAG_GROOT_VERSION) | ||
| docker tag $(LOCAL_TAG_GROOT) $(TAG_GROOT_SHA) | ||
| @echo "Tagged with:" | ||
| @echo " - $(TAG_GROOT_LATEST)" | ||
| @echo " - $(TAG_GROOT_VERSION)" | ||
| @echo " - $(TAG_GROOT_SHA)" | ||
|
|
||
| push: tag | ||
| @echo "Pushing groot images to Docker Hub..." | ||
| docker push $(TAG_GROOT_LATEST) | ||
| docker push $(TAG_GROOT_VERSION) | ||
| docker push $(TAG_GROOT_SHA) | ||
| @echo "" | ||
| @echo "Successfully pushed groot images to Docker Hub!" | ||
| @echo "To use on cloud instances, set:" | ||
| @echo " export IMAGE_REGISTRY=$(REGISTRY_URL)/" | ||
|
|
||
| all: push | ||
|
|
||
| clean: | ||
| @echo "Removing local groot images..." | ||
| -docker rmi $(LOCAL_TAG_GROOT) | ||
| -docker rmi $(TAG_GROOT_LATEST) | ||
| -docker rmi $(TAG_GROOT_VERSION) | ||
| -docker rmi $(TAG_GROOT_SHA) | ||
| @echo "Cleanup complete." | ||
|
|
||
| prune: | ||
| @echo "Pruning dangling and unused Docker images..." | ||
| docker image prune -f | ||
| @echo "Prune complete." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this workflow builds the published image,
actions/checkoutleaves submodules uninitialized by default (itssubmodulesinput defaults to false), so Docker'sCOPY . /gr00tpackages emptyexternal_dependenciespaths;.dockerignorealso strips.git, preventing/gr00tfrom initializing them later. The LIBERO and SimplerEnv setup scripts immediately rungit submodule update, which then fails because the included checkout is not a Git repository, making simulation evaluation unavailable from this image. Configure checkout withsubmodules: recursivebeforemake push.Useful? React with 👍 / 👎.