Skip to content
This repository was archived by the owner on Aug 6, 2026. It is now read-only.

fix: prevent skipping incomplete loop steps - #3761

Merged
trunk-io[bot] merged 2 commits into
mainfrom
posthog-code/fix-loops-step-navigation
Jul 23, 2026
Merged

fix: prevent skipping incomplete loop steps#3761
trunk-io[bot] merged 2 commits into
mainfrom
posthog-code/fix-loops-step-navigation

Conversation

@MattPua

@MattPua MattPua commented Jul 23, 2026

Copy link
Copy Markdown
Member

Problem

Users can bypass required fields in the new loop flow by clicking later steps in the progress indicator.

Changes

  • Block forward step navigation until intervening steps are complete
  • Keep backward navigation available
  • Add focused navigation tests
  • No visual change

How did you test this?

  • pnpm exec vitest run packages/ui/src/features/loops/components/LoopForm.test.ts
  • pnpm exec biome check packages/ui/src/features/loops/components/LoopForm.tsx packages/ui/src/features/loops/components/LoopForm.test.ts packages/ui/src/features/loops/components/loopStepNavigation.ts
  • pnpm --filter @posthog/ui typecheck
  • Full pnpm typecheck via pre-commit hook

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

Generated-By: PostHog Code
Task-Id: 05d83215-fe0a-4441-8c70-c3063488a351
@trunk-io

trunk-io Bot commented Jul 23, 2026

Copy link
Copy Markdown

😎 Merged successfully - details.

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 25f49bd.

Comment thread packages/ui/src/features/loops/components/loopStepNavigation.ts Outdated
Comment thread packages/ui/src/features/loops/components/LoopForm.test.ts Outdated
Generated-By: PostHog Code
Task-Id: a9a17cbf-42db-48e0-aadb-f7d77d145d39
@MattPua
MattPua marked this pull request as ready for review July 23, 2026 15:02
@MattPua MattPua added the Stamphog This will request an autostamp by stamphog on small changes label Jul 23, 2026
@greptile-apps

greptile-apps Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "refactor: inline loop step navigation gu..." | Re-trigger Greptile

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial, contained UI fix to step navigation gating with added tests; no risky territory touched and no unresolved concerns.

  • Author wrote 0% of the modified lines and has 6 merged PRs in these paths (familiarity MODERATE).
  • 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 11L, 1F substantive — within ceiling
tier T1-agent / T1a-trivial (11L, 1F, single-area, fix)
stamphog 2.0.0b3 .stamphog/policy.yml @ dec9229 · reviewed head 25f49bd

@trunk-io
trunk-io Bot merged commit c9605b5 into main Jul 23, 2026
44 of 45 checks passed
@trunk-io
trunk-io Bot deleted the posthog-code/fix-loops-step-navigation branch July 23, 2026 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Stamphog This will request an autostamp by stamphog on small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant