This repository was archived by the owner on Aug 6, 2026. It is now read-only.
fix: prevent skipping incomplete loop steps - #3761
Merged
Merged
Conversation
Generated-By: PostHog Code Task-Id: 05d83215-fe0a-4441-8c70-c3063488a351
|
😎 Merged successfully - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
MattPua
commented
Jul 23, 2026
Generated-By: PostHog Code Task-Id: a9a17cbf-42db-48e0-aadb-f7d77d145d39
MattPua
marked this pull request as ready for review
July 23, 2026 15:02
Contributor
|
Reviews (1): Last reviewed commit: "refactor: inline loop step navigation gu..." | Re-trigger Greptile |
There was a problem hiding this comment.
Trivial, contained UI fix to step navigation gating with added tests; no risky territory touched and no unresolved concerns.
- Author wrote 0% of the modified lines and has 6 merged PRs in these paths (familiarity MODERATE).
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 11L, 1F substantive — within ceiling |
| tier | ✓ | T1-agent / T1a-trivial (11L, 1F, single-area, fix) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ dec9229 · reviewed head 25f49bd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users can bypass required fields in the new loop flow by clicking later steps in the progress indicator.
Changes
How did you test this?
pnpm exec vitest run packages/ui/src/features/loops/components/LoopForm.test.tspnpm exec biome check packages/ui/src/features/loops/components/LoopForm.tsx packages/ui/src/features/loops/components/LoopForm.test.ts packages/ui/src/features/loops/components/loopStepNavigation.tspnpm --filter @posthog/ui typecheckpnpm typecheckvia pre-commit hookAutomatic notifications
Created with PostHog Code