Skip to content
This repository was archived by the owner on Aug 6, 2026. It is now read-only.

fix: prevent skipping incomplete loop steps #3761

Merged
trunk-io merged 2 commits into from
Jul 23, 2026
Merged

fix: prevent skipping incomplete loop steps #3761

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
359976c
fix: prevent skipping incomplete loop steps
MattPua Jul 23, 2026
25f49bd
refactor: inline loop step navigation guard
MattPua Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/ui/src/features/loops/components/LoopForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,8 +446,8 @@ function Stepper({
{STEPS.map((label, index) => {
const isCurrent = index === current;
const isDone = index < current && complete[index];
// Steps navigate freely in both directions; skipping ahead is safe
// because Next stays gated per step and Create on the whole form.
const canSelect =
index <= current || complete.slice(current, index).every(Boolean);
return (
<Flex
key={label}
Expand All @@ -456,8 +456,11 @@ function Stepper({
>
<button
type="button"
onClick={() => onSelect(index)}
className="flex min-w-0 cursor-pointer items-center gap-2"
disabled={!canSelect}
onClick={() => {
if (canSelect) onSelect(index);
}}
className="flex min-w-0 cursor-pointer items-center gap-2 disabled:cursor-not-allowed disabled:opacity-50"
>
<Flex
align="center"
Expand Down
Loading