fix(tasks): download artifacts without pop-ups - #3790
Merged
Conversation
|
😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details. |
tatoalo
marked this pull request as ready for review
July 24, 2026 13:55
VojtechBartos
approved these changes
Jul 24, 2026
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
packages/ui/src/features/sessions/components/CloudArtifactDownloads.tsx:73
**Desktop blocks the blank popup**
When a user downloads an artifact in the Electron app, the desktop window handler unconditionally denies this `window.open` call, causing the function to return with an “Allow pop-ups” toast instead of opening the file.
Reviews (1): Last reviewed commit: "fix(tasks): preserve user activation for..." | Re-trigger Greptile |
tatoalo
force-pushed
the
posthog-code/fix-artifact-download-popup
branch
from
July 24, 2026 14:01
99c078f to
b9b5675
Compare
Generated-By: PostHog Code Task-Id: 0a111328-1757-4b88-aec3-0725e3733bdb
tatoalo
force-pushed
the
posthog-code/fix-artifact-download-popup
branch
from
July 24, 2026 14:02
b9b5675 to
5080706
Compare
tatoalo
enabled auto-merge (squash)
July 24, 2026 14:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Artifact downloads were blocked in the desktop and web hosts because opening a new tab requires pop-up permission. Follow-up to #3788.
Changes
Fetch the presigned artifact directly and trigger a local blob download with the original filename. This avoids pop-ups and keeps image artifacts from replacing the app.
How did you test this?
pnpm --filter @posthog/ui exec vitest run src/features/sessions/components/CloudArtifactDownloads.test.tsxpnpm --filter @posthog/ui typecheckpnpm biome check packages/ui/src/features/sessions/components/CloudArtifactDownloads.tsx packages/ui/src/features/sessions/components/CloudArtifactDownloads.test.tsxAutomatic notifications
Created with PostHog Code