Skip to content

fix(tasks): download artifacts without pop-ups #3790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trunk-io merged 1 commit into from
Jul 24, 2026
Merged

fix(tasks): download artifacts without pop-ups #3790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions packages/ui/src/features/sessions/components/CloudArtifactDownloads.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,25 @@ const task = {
describe("CloudArtifactDownloads", () => {
beforeEach(() => {
getCloudAttachmentPreviewUrl.mockReset();
vi.restoreAllMocks();
});

it("shows output artifacts and opens their download URL", async () => {
getCloudAttachmentPreviewUrl.mockResolvedValue(
"https://files.example/report.pdf",
);
const open = vi.spyOn(window, "open").mockImplementation(() => null);
const fetchArtifact = vi
.spyOn(window, "fetch")
.mockResolvedValue(new Response("file contents"));
const createObjectURL = vi
.spyOn(URL, "createObjectURL")
.mockReturnValue("blob:artifact");
const revokeObjectURL = vi
.spyOn(URL, "revokeObjectURL")
.mockImplementation(() => undefined);
const click = vi
.spyOn(HTMLAnchorElement.prototype, "click")
.mockImplementation(() => undefined);

render(
<Theme>
Expand All @@ -70,15 +82,14 @@ describe("CloudArtifactDownloads", () => {
expect(screen.getByText("12 KB")).toBeInTheDocument();
expect(screen.queryByText("handoff.pack")).not.toBeInTheDocument();

fireEvent.click(screen.getByRole("button", { name: "Download" }));
fireEvent.click(screen.getByText("Download"));

await waitFor(() =>
expect(open).toHaveBeenCalledWith(
"https://files.example/report.pdf",
"_blank",
"noopener,noreferrer",
),
await waitFor(() => expect(click).toHaveBeenCalledOnce());
expect(fetchArtifact).toHaveBeenCalledWith(
"https://files.example/report.pdf",
);
expect(createObjectURL).toHaveBeenCalledOnce();
expect(revokeObjectURL).toHaveBeenCalledWith("blob:artifact");
expect(getCloudAttachmentPreviewUrl).toHaveBeenCalledWith(
"task-1",
"run-1",
Expand Down
9 changes: 8 additions & 1 deletion packages/ui/src/features/sessions/components/CloudArtifactDownloads.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,14 @@ export function CloudArtifactDownloads({
toast.error("This file is no longer available");
return;
}
window.open(url, "_blank", "noopener,noreferrer");
const response = await fetch(url);
if (!response.ok) throw new Error("Artifact download failed");
const objectUrl = URL.createObjectURL(await response.blob());
const anchor = document.createElement("a");
anchor.href = objectUrl;
anchor.download = artifact.name;
anchor.click();
URL.revokeObjectURL(objectUrl);
} catch {
toast.error("Couldn't download file");
} finally {
Expand Down
Loading