Skip to content

fix(ui): remove unfinished comments tab #3948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trunk-io merged 1 commit into from
Jul 29, 2026
Merged

fix(ui): remove unfinished comments tab #3948

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 2 additions & 27 deletions packages/ui/src/features/canvas/components/ActivityPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import {
AgentStatusLine,
ThreadLoadingState,
ThreadReplyComposer,
ThreadTimeline,
} from "@posthog/ui/features/canvas/components/ThreadPanel";
import { useThreadConversation } from "@posthog/ui/features/canvas/hooks/useThreadConversation";
import { buildConversationItems } from "@posthog/ui/features/sessions/components/buildConversationItems";
Expand All @@ -22,19 +21,13 @@ import { track } from "@posthog/ui/shell/analytics";
import { useQuery } from "@tanstack/react-query";
import { useCallback, useEffect, useMemo, useRef, useState } from "react";

type ActivityTab = "timeline" | "artifacts" | "comments";
type ActivityTab = "timeline" | "artifacts";

const ACTIVITY_TABS: readonly { key: ActivityTab; label: string }[] = [
{ key: "timeline", label: "Timeline" },
{ key: "artifacts", label: "Artifacts" },
{ key: "comments", label: "Comments" },
] as const;

const TABS_WITH_COMPOSER: ReadonlySet<ActivityTab> = new Set([
"timeline",
"comments",
]);

/** The 32px row this panel leads with: the tabs are the header, so the strip
* lines up with the tab bar of the pane on its left (TabbedPanel) and the
* review toolbar, which are the same fixed height and border. */
Expand Down Expand Up @@ -160,10 +153,6 @@ function ActivityConversation({
[taskId],
);

const commentRows = useMemo(
() => timeline.filter((row) => row.kind === "human"),
[timeline],
);
const conversationItems = useMemo(
() =>
tab === "timeline"
Expand All @@ -178,7 +167,7 @@ function ActivityConversation({
scrollRef.current?.scrollTo({ top: scrollRef.current.scrollHeight });
}, [timeline, events.length, agentStatus?.phase, tab]);

const showComposer = TABS_WITH_COMPOSER.has(tab);
const showComposer = tab === "timeline";

const body = () => {
if (tab === "artifacts") {
Expand All @@ -190,20 +179,6 @@ function ActivityConversation({
/>
);
}
if (tab === "comments") {
return (
<ThreadTimeline
timeline={commentRows}
isReady={isReady}
currentUserUuid={currentUser?.uuid}
currentUserEmail={currentUser?.email}
isTaskAuthor={isTaskAuthor}
canForward={canForward}
onSendToAgent={sendMessageToAgent}
onDelete={deleteMessage}
/>
);
}
if (!isReady) return <ThreadLoadingState />;
return (
<ActivityTimeline
Expand Down
Loading