feat(ui): Top security researchers ranking#237
Merged
Conversation
New Top card and Wall of Fame tab fed by top_security.json (produced by traces:fetch:security-advisories + traces:generate:topsecurity). Ranks contributors credited as security researchers (finder, reporter, analyst) on published advisories — remediation credits are left out since core developers who ship the fix are already surfaced in the PR and commit leaderboards. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
|
@PrestaEdit PrestaShop/traces#235 is merged |
Contributor
Author
|
Thanks @Progi1984 — I also see v6.4.0 was tagged right before your comment, so the On this PR side: it's ready for you to merge whenever you want, nothing else pending from me. Worth restating (it's already in the description): the ranking will stay sparse until the GitHub credits on advisories published since May 2024 get filled in — that's a security-team process topic to raise separately. |
Progi1984
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Security researchers who find and report vulnerabilities never appear on the site today: fixes go through a private security repo and are republished by the core team, so the original reporter is lost from the PR/commit history. This surfaces them from the GitHub security-advisory credits instead.
What this does
Both are fed by
top_security.json(produced by the companiontracescommands) and reuse the existing ranking table — sameRank / Name / Advisorieslayout as the reviewers / issues / PR rankings. The card and tab are hidden automatically when the data file is absent, so nothing breaks if the JSON isn't there yet.The ranking counts research credits only (finder / reporter / analyst) — remediation credits go to core developers already counted in the other leaderboards. See the companion traces PR for the rationale.
Pipeline
.github/workflows/gh-pages.ymlgets two new steps (fetch + generate) and publishestop_security.jsonalongside the other data files.This depends on the traces PR: PrestaShop/traces#235. The
mv top_security.jsonstep here will fail until a traces release that includes those commands is published. Suggested order:Checks
vitestgreen (10/10), including updated coverage for the new card and tab.No PrestaShop advisory published since ~May 2024 has its credits filled in, so the ranking currently shows mostly 2020–2024 history and will stay sparse until credits are entered going forward. Credits are retro-editable on published advisories — filling them is a security-team process topic, not a code change here. This feature is meant to be the concrete argument for making that part of the advisory workflow.
🤖 Generated with Claude Code